Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, 2019-12-03 at 17:10 +, Andrew Cooper wrote: > Like %cr2 for pagefaults, %dr6 contains ancillary information for > debug > exceptions, and needs similar handling. > > For xendevicemodel_inject_event(), no ABI change is needed (although > an API > one would be ideal). Switch from 'cr2'

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Wed, 2019-12-04 at 10:04 +0100, Jan Beulich wrote: > On 03.12.2019 18:10, Andrew Cooper wrote: > > --- a/xen/include/public/hvm/dm_op.h > > +++ b/xen/include/public/hvm/dm_op.h > > @@ -324,7 +324,7 @@ struct xen_dm_op_inject_event { > > /* IN - error code (or ~0 to skip) */ > >

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On 03.12.2019 18:10, Andrew Cooper wrote: > --- a/xen/include/public/hvm/dm_op.h > +++ b/xen/include/public/hvm/dm_op.h > @@ -324,7 +324,7 @@ struct xen_dm_op_inject_event { > /* IN - error code (or ~0 to skip) */ > uint32_t error_code; > uint32_t pad1; > -/* IN - CR2 for page

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h > index 959083d8c4..76676ff4c0 100644 > --- a/xen/include/public/vm_event.h > +++ b/xen/include/public/vm_event.h > @@ -281,6 +281,7 @@ struct vm_event_debug { > uint32_t insn_length; > uint8_t type;/*

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, Dec 3, 2019 at 1:23 PM Andrew Cooper wrote: > > On 03/12/2019 18:16, Tamas K Lengyel wrote: > > On Tue, Dec 3, 2019 at 1:09 PM Andrew Cooper > > wrote: > >> On 03/12/2019 18:05, Tamas K Lengyel wrote: > diff --git a/xen/include/public/vm_event.h >

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, Dec 3, 2019 at 1:09 PM Andrew Cooper wrote: > > On 03/12/2019 18:05, Tamas K Lengyel wrote: > >> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h > >> index 959083d8c4..76676ff4c0 100644 > >> --- a/xen/include/public/vm_event.h > >> +++

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, Dec 3, 2019 at 1:31 PM Andrew Cooper wrote: > > On 03/12/2019 18:24, Tamas K Lengyel wrote: > > On Tue, Dec 3, 2019 at 1:22 PM Tamas K Lengyel wrote: > >> On Tue, Dec 3, 2019 at 1:18 PM Andrew Cooper > >> wrote: > >>> On 03/12/2019 18:09, Tamas K Lengyel wrote: > On Tue, Dec 3,

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, Dec 3, 2019 at 1:18 PM Andrew Cooper wrote: > > On 03/12/2019 18:09, Tamas K Lengyel wrote: > > On Tue, Dec 3, 2019 at 1:05 PM Tamas K Lengyel wrote: > >>> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h > >>> index 959083d8c4..76676ff4c0 100644 > >>> ---

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, Dec 3, 2019 at 1:23 PM Andrew Cooper wrote: > > On 03/12/2019 18:16, Tamas K Lengyel wrote: > > On Tue, Dec 3, 2019 at 1:09 PM Andrew Cooper > > wrote: > >> On 03/12/2019 18:05, Tamas K Lengyel wrote: > diff --git a/xen/include/public/vm_event.h >

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On 03/12/2019 18:24, Tamas K Lengyel wrote: > On Tue, Dec 3, 2019 at 1:22 PM Tamas K Lengyel wrote: >> On Tue, Dec 3, 2019 at 1:18 PM Andrew Cooper >> wrote: >>> On 03/12/2019 18:09, Tamas K Lengyel wrote: On Tue, Dec 3, 2019 at 1:05 PM Tamas K Lengyel wrote: >> diff --git

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, Dec 3, 2019 at 1:22 PM Tamas K Lengyel wrote: > > On Tue, Dec 3, 2019 at 1:18 PM Andrew Cooper > wrote: > > > > On 03/12/2019 18:09, Tamas K Lengyel wrote: > > > On Tue, Dec 3, 2019 at 1:05 PM Tamas K Lengyel > > > wrote: > > >>> diff --git a/xen/include/public/vm_event.h > > >>>

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On 03/12/2019 18:16, Tamas K Lengyel wrote: > On Tue, Dec 3, 2019 at 1:09 PM Andrew Cooper > wrote: >> On 03/12/2019 18:05, Tamas K Lengyel wrote: diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h index 959083d8c4..76676ff4c0 100644 ---

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On Tue, Dec 3, 2019 at 1:05 PM Tamas K Lengyel wrote: > > > diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h > > index 959083d8c4..76676ff4c0 100644 > > --- a/xen/include/public/vm_event.h > > +++ b/xen/include/public/vm_event.h > > @@ -281,6 +281,7 @@ struct

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On 03/12/2019 18:09, Tamas K Lengyel wrote: > On Tue, Dec 3, 2019 at 1:05 PM Tamas K Lengyel wrote: >>> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h >>> index 959083d8c4..76676ff4c0 100644 >>> --- a/xen/include/public/vm_event.h >>> +++

Re: [Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

On 03/12/2019 18:05, Tamas K Lengyel wrote: >> diff --git a/xen/include/public/vm_event.h b/xen/include/public/vm_event.h >> index 959083d8c4..76676ff4c0 100644 >> --- a/xen/include/public/vm_event.h >> +++ b/xen/include/public/vm_event.h >> @@ -281,6 +281,7 @@ struct vm_event_debug { >>

[Xen-devel] [PATCH] x86/debug: Plumb pending_dbg through the monitor and devicemodel interfaces

Like %cr2 for pagefaults, %dr6 contains ancillary information for debug exceptions, and needs similar handling. For xendevicemodel_inject_event(), no ABI change is needed (although an API one would be ideal). Switch from 'cr2' to 'extra' in variable names which don't constitute an API change,