Re: [Xen-devel] [PATCH] x86/livepatch: Fail the build if duplicate symbols exist

2019-04-12 Thread Jan Beulich
>>> On 11.04.19 at 21:51, wrote: > On 08/04/2019 11:53, Jan Beulich wrote: > On 08.04.19 at 12:11, wrote: >>> On 08/04/2019 10:52, Jan Beulich wrote: >>> On 05.04.19 at 23:02, wrote: > On Fri, Apr 05, 2019 at 08:26:04PM +0100, Andrew Cooper wrote: >> From: Ross Lagerwall >>

Re: [Xen-devel] [PATCH] x86/livepatch: Fail the build if duplicate symbols exist

2019-04-11 Thread Andrew Cooper
On 08/04/2019 11:53, Jan Beulich wrote: On 08.04.19 at 12:11, wrote: >> On 08/04/2019 10:52, Jan Beulich wrote: >> On 05.04.19 at 23:02, wrote: On Fri, Apr 05, 2019 at 08:26:04PM +0100, Andrew Cooper wrote: > From: Ross Lagerwall > > The binary diffing algorithm used by

Re: [Xen-devel] [PATCH] x86/livepatch: Fail the build if duplicate symbols exist

2019-04-08 Thread Jan Beulich
>>> On 08.04.19 at 12:11, wrote: > On 08/04/2019 10:52, Jan Beulich wrote: > On 05.04.19 at 23:02, wrote: >>> On Fri, Apr 05, 2019 at 08:26:04PM +0100, Andrew Cooper wrote: From: Ross Lagerwall The binary diffing algorithm used by xen-livepatch depends on having unique sy

Re: [Xen-devel] [PATCH] x86/livepatch: Fail the build if duplicate symbols exist

2019-04-08 Thread Andrew Cooper
On 08/04/2019 10:52, Jan Beulich wrote: On 05.04.19 at 23:02, wrote: >> On Fri, Apr 05, 2019 at 08:26:04PM +0100, Andrew Cooper wrote: >>> From: Ross Lagerwall >>> >>> The binary diffing algorithm used by xen-livepatch depends on having unique >>> symbols. > Question: Is this an inherent req

Re: [Xen-devel] [PATCH] x86/livepatch: Fail the build if duplicate symbols exist

2019-04-08 Thread Jan Beulich
>>> On 05.04.19 at 23:02, wrote: > On Fri, Apr 05, 2019 at 08:26:04PM +0100, Andrew Cooper wrote: >> From: Ross Lagerwall >> >> The binary diffing algorithm used by xen-livepatch depends on having unique >> symbols. Question: Is this an inherent requirement, or an effect of the current implemen

Re: [Xen-devel] [PATCH] x86/livepatch: Fail the build if duplicate symbols exist

2019-04-05 Thread Konrad Rzeszutek Wilk
On Fri, Apr 05, 2019 at 08:26:04PM +0100, Andrew Cooper wrote: > From: Ross Lagerwall > > The binary diffing algorithm used by xen-livepatch depends on having unique > symbols. > > Signed-off-by: Ross Lagerwall > Signed-off-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Wilk > --- > CC: Ja

[Xen-devel] [PATCH] x86/livepatch: Fail the build if duplicate symbols exist

2019-04-05 Thread Andrew Cooper
From: Ross Lagerwall The binary diffing algorithm used by xen-livepatch depends on having unique symbols. Signed-off-by: Ross Lagerwall Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné CC: Stefano Stabellini CC: Julien Grall CC: Ross Lagerwall CC: Konrad R