Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Tamas K Lengyel
On Wed, May 1, 2019 at 11:03 AM Andrew Cooper wrote: > > On 01/05/2019 15:58, Tamas K Lengyel wrote: > > On Wed, May 1, 2019 at 7:45 AM Tamas K Lengyel wrote: > >> On Wed, May 1, 2019 at 1:50 AM Andrew Cooper > >> wrote: > >>> On 01/05/2019 05:22, Tamas K Lengyel wrote: > Currently the

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Andrew Cooper
On 01/05/2019 15:58, Tamas K Lengyel wrote: > On Wed, May 1, 2019 at 7:45 AM Tamas K Lengyel wrote: >> On Wed, May 1, 2019 at 1:50 AM Andrew Cooper >> wrote: >>> On 01/05/2019 05:22, Tamas K Lengyel wrote: Currently the gs_shadow value is only cached when the vCPU is being scheduled

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Tamas K Lengyel
On Wed, May 1, 2019 at 9:44 AM Razvan Cojocaru wrote: > > On 5/1/19 6:01 PM, Tamas K Lengyel wrote: > > On Wed, May 1, 2019 at 8:53 AM Tamas K Lengyel wrote: > >> > >> On Wed, May 1, 2019 at 8:20 AM Razvan Cojocaru > >> wrote: > >>> > >>> On 5/1/19 4:58 PM, Tamas K Lengyel wrote: > >> It

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Razvan Cojocaru
On 5/1/19 6:01 PM, Tamas K Lengyel wrote: > On Wed, May 1, 2019 at 8:53 AM Tamas K Lengyel wrote: >> >> On Wed, May 1, 2019 at 8:20 AM Razvan Cojocaru >> wrote: >>> >>> On 5/1/19 4:58 PM, Tamas K Lengyel wrote: >> It might be worth introducing a "sync state from hw" hook which collects

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Tamas K Lengyel
On Wed, May 1, 2019 at 8:53 AM Tamas K Lengyel wrote: > > On Wed, May 1, 2019 at 8:20 AM Razvan Cojocaru > wrote: > > > > On 5/1/19 4:58 PM, Tamas K Lengyel wrote: > > >>> It might be worth introducing a "sync state from hw" hook which collects > > >>> all the data we intend to pass to the

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Tamas K Lengyel
On Wed, May 1, 2019 at 7:45 AM Tamas K Lengyel wrote: > > On Wed, May 1, 2019 at 1:50 AM Andrew Cooper > wrote: > > > > On 01/05/2019 05:22, Tamas K Lengyel wrote: > > > Currently the gs_shadow value is only cached when the vCPU is being > > > scheduled > > > out by Xen. Reporting this

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Tamas K Lengyel
On Wed, May 1, 2019 at 8:20 AM Razvan Cojocaru wrote: > > On 5/1/19 4:58 PM, Tamas K Lengyel wrote: > >>> It might be worth introducing a "sync state from hw" hook which collects > >>> all the data we intend to pass to the introspection agent. > >> > >> You mean adding another hvm hook? > > > >

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Razvan Cojocaru
On 5/1/19 4:58 PM, Tamas K Lengyel wrote: >>> It might be worth introducing a "sync state from hw" hook which collects >>> all the data we intend to pass to the introspection agent. >> >> You mean adding another hvm hook? > > Actually, instead of another hook I think what would make sense it to >

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Tamas K Lengyel
> > It might be worth introducing a "sync state from hw" hook which collects > > all the data we intend to pass to the introspection agent. > > You mean adding another hvm hook? Actually, instead of another hook I think what would make sense it to just update vmx_save_vmcs_ctxt to automatically

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Tamas K Lengyel
On Wed, May 1, 2019 at 1:50 AM Andrew Cooper wrote: > > On 01/05/2019 05:22, Tamas K Lengyel wrote: > > Currently the gs_shadow value is only cached when the vCPU is being > > scheduled > > out by Xen. Reporting this (usually) stale value through vm_event is > > incorrect, > > since it doesn't

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Andrew Cooper
On 01/05/2019 05:22, Tamas K Lengyel wrote: > Currently the gs_shadow value is only cached when the vCPU is being scheduled > out by Xen. Reporting this (usually) stale value through vm_event is > incorrect, > since it doesn't represent the actual state of the vCPU at the time the event > was

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Andrew Cooper
On 01/05/2019 08:17, Razvan Cojocaru wrote: > On 5/1/19 7:22 AM, Tamas K Lengyel wrote: >> Currently the gs_shadow value is only cached when the vCPU is being scheduled >> out by Xen. Reporting this (usually) stale value through vm_event is >> incorrect, >> since it doesn't represent the actual

Re: [Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-05-01 Thread Razvan Cojocaru
On 5/1/19 7:22 AM, Tamas K Lengyel wrote: > Currently the gs_shadow value is only cached when the vCPU is being scheduled > out by Xen. Reporting this (usually) stale value through vm_event is > incorrect, > since it doesn't represent the actual state of the vCPU at the time the event > was

[Xen-devel] [PATCH] x86/vm_event: correctly gather gs_shadow value

2019-04-30 Thread Tamas K Lengyel
Currently the gs_shadow value is only cached when the vCPU is being scheduled out by Xen. Reporting this (usually) stale value through vm_event is incorrect, since it doesn't represent the actual state of the vCPU at the time the event was recorded. This prevents vm_event subscribers from