Re: [Xen-devel] [PATCH] x86/vtx: Introduce a typed union for CR access exit information

2018-03-20 Thread Jan Beulich
>>> On 20.03.18 at 15:28, wrote: > On 20/03/18 10:51, Jan Beulich wrote: > On 15.03.18 at 13:07, wrote: >>> +typedef union cr_access_qual { >>> +unsigned long raw; >>> +struct { >>> +uint16_t cr:4, >>> +

Re: [Xen-devel] [PATCH] x86/vtx: Introduce a typed union for CR access exit information

2018-03-20 Thread Andrew Cooper
On 20/03/18 10:51, Jan Beulich wrote: On 15.03.18 at 13:07, wrote: >> --- a/xen/arch/x86/hvm/vmx/vvmx.c >> +++ b/xen/arch/x86/hvm/vmx/vvmx.c >> @@ -2448,27 +2448,24 @@ int nvmx_n2_vmexit_handler(struct cpu_user_regs >> *regs, >> break; >> case

Re: [Xen-devel] [PATCH] x86/vtx: Introduce a typed union for CR access exit information

2018-03-20 Thread Jan Beulich
>>> On 15.03.18 at 13:07, wrote: > --- a/xen/arch/x86/hvm/vmx/vvmx.c > +++ b/xen/arch/x86/hvm/vmx/vvmx.c > @@ -2448,27 +2448,24 @@ int nvmx_n2_vmexit_handler(struct cpu_user_regs *regs, > break; > case EXIT_REASON_CR_ACCESS: > { > -unsigned

Re: [Xen-devel] [PATCH] x86/vtx: Introduce a typed union for CR access exit information

2018-03-19 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Thursday, March 15, 2018 8:08 PM > > This reduces code volume, and has a minor improvement on compiled size, > probably due to the removal of several temporary variables. > > add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-50 (-50)

[Xen-devel] [PATCH] x86/vtx: Introduce a typed union for CR access exit information

2018-03-15 Thread Andrew Cooper
This reduces code volume, and has a minor improvement on compiled size, probably due to the removal of several temporary variables. add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-50 (-50) function old new delta vmx_vmexit_handler