Re: [Xen-devel] [PATCH] x86: use alternatives for FS/GS base accesses

2018-09-26 Thread Jan Beulich
>>> On 26.09.18 at 20:13, wrote: > On 26/09/18 07:43, Jan Beulich wrote: >> Eliminating conditional branches is always a Good Thing (tm), it seems to > me. > > By this reasoning, we should compile Xen with movfuscator, which really > will get rid of every branch. > > Doing so would be utter non

Re: [Xen-devel] [PATCH] x86: use alternatives for FS/GS base accesses

2018-09-26 Thread Andrew Cooper
On 26/09/18 07:43, Jan Beulich wrote: On 25.09.18 at 18:52, wrote: >> On 29/08/18 17:03, Jan Beulich wrote: >>> Eliminates a couple of branches in particular from the context switch >>> path. >>> >>> Signed-off-by: Jan Beulich >> I've already expressed a dis-inclination to this patch, becaus

Re: [Xen-devel] [PATCH] x86: use alternatives for FS/GS base accesses

2018-09-25 Thread Jan Beulich
>>> On 25.09.18 at 18:52, wrote: > On 29/08/18 17:03, Jan Beulich wrote: >> Eliminates a couple of branches in particular from the context switch >> path. >> >> Signed-off-by: Jan Beulich > > I've already expressed a dis-inclination to this patch, because it looks > like a micro-optimisation whi

Re: [Xen-devel] [PATCH] x86: use alternatives for FS/GS base accesses

2018-09-25 Thread Andrew Cooper
On 29/08/18 17:03, Jan Beulich wrote: > Eliminates a couple of branches in particular from the context switch > path. > > Signed-off-by: Jan Beulich I've already expressed a dis-inclination to this patch, because it looks like a micro-optimisation which won't actually affect measureable performan

Re: [Xen-devel] [PATCH] x86: use alternatives for FS/GS base accesses

2018-08-30 Thread Wei Liu
On Wed, Aug 29, 2018 at 10:03:01AM -0600, Jan Beulich wrote: > Eliminates a couple of branches in particular from the context switch > path. > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu ___ Xen-devel mailing list Xen-devel@lists.xenproject.org

[Xen-devel] [PATCH] x86: use alternatives for FS/GS base accesses

2018-08-29 Thread Jan Beulich
Eliminates a couple of branches in particular from the context switch path. Signed-off-by: Jan Beulich --- a/xen/include/asm-x86/msr.h +++ b/xen/include/asm-x86/msr.h @@ -11,6 +11,7 @@ #include +#include #include #include #include @@ -154,10 +155,15 @@ static inline unsigned long rd