Re: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-22 Thread Julien Grall
Hi David, On 22/01/2020 13:50, Woodhouse, David wrote: On Wed, 2020-01-22 at 13:15 +, Andrew Cooper wrote: I'd much rather see the original patch reverted. The current size of struct domain with lockprofile enabled is 3200 bytes. Let me have a look first to see when/why struct domain is

Re: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-22 Thread Woodhouse, David
On Wed, 2020-01-22 at 13:15 +, Andrew Cooper wrote: > > > I'd much rather see the original patch reverted. The current size of > > > struct domain with lockprofile enabled is 3200 bytes. > > > > Let me have a look first to see when/why struct domain is less than 4K > > with lockprofile. > >

Re: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-22 Thread Andrew Cooper
On 22/01/2020 13:13, Julien Grall wrote: > Hi Andrew, > > On 22/01/2020 12:52, Andrew Cooper wrote: >> On 20/01/2020 14:31, Julien Grall wrote: >>> From: Julien Grall >>> >>> The structure domain may be bigger than a page size when lock profiling >>> is enabled. However, the function

Re: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-22 Thread Julien Grall
Hi Andrew, On 22/01/2020 12:52, Andrew Cooper wrote: On 20/01/2020 14:31, Julien Grall wrote: From: Julien Grall The structure domain may be bigger than a page size when lock profiling is enabled. However, the function free_domheap_struct will only free the first page. This is not a

Re: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-22 Thread Andrew Cooper
On 20/01/2020 14:31, Julien Grall wrote: > From: Julien Grall > > The structure domain may be bigger than a page size when lock profiling > is enabled. However, the function free_domheap_struct will only free the > first page. > > This is not a security issue because struct domain can only be

Re: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-20 Thread Roger Pau Monné
On Mon, Jan 20, 2020 at 02:31:42PM +, Julien Grall wrote: > From: Julien Grall > > The structure domain may be bigger than a page size when lock profiling > is enabled. However, the function free_domheap_struct will only free the > first page. > > This is not a security issue because struct

Re: [Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-20 Thread Jan Beulich
On 20.01.2020 15:31, Julien Grall wrote: > From: Julien Grall > > The structure domain may be bigger than a page size when lock profiling > is enabled. However, the function free_domheap_struct will only free the > first page. > > This is not a security issue because struct domain can only be

[Xen-devel] [PATCH] xen/x86: domain: Free all the pages associated to struct domain

2020-01-20 Thread Julien Grall
From: Julien Grall The structure domain may be bigger than a page size when lock profiling is enabled. However, the function free_domheap_struct will only free the first page. This is not a security issue because struct domain can only be bigger than a page size for lock profiling. The feature