Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Jan Beulich
>>> On 04.01.18 at 17:35, wrote: > On Thu, Jan 4, 2018 at 9:25 AM, Jan Beulich wrote: > On 04.01.18 at 17:16, wrote: >>> On Thu, Jan 4, 2018 at 8:00 AM, Jan Beulich wrote: >>> On 04.01.18 at 15:39,

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Tamas K Lengyel
On Thu, Jan 4, 2018 at 9:25 AM, Jan Beulich wrote: On 04.01.18 at 17:16, wrote: >> On Thu, Jan 4, 2018 at 8:00 AM, Jan Beulich wrote: >> On 04.01.18 at 15:39, wrote: On Thu, Jan 4, 2018 at 3:43 AM,

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Jan Beulich
>>> On 04.01.18 at 17:16, wrote: > On Thu, Jan 4, 2018 at 8:00 AM, Jan Beulich wrote: > On 04.01.18 at 15:39, wrote: >>> On Thu, Jan 4, 2018 at 3:43 AM, Jan Beulich wrote: Just looking at the low bit of

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Tamas K Lengyel
On Thu, Jan 4, 2018 at 8:00 AM, Jan Beulich wrote: On 04.01.18 at 15:39, wrote: >> On Thu, Jan 4, 2018 at 3:43 AM, Jan Beulich wrote: >>> Just looking at the low bit of the first >>> byte before assuming this could be a load option

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Jan Beulich
>>> On 04.01.18 at 15:39, wrote: > On Thu, Jan 4, 2018 at 3:43 AM, Jan Beulich wrote: >> Just looking at the low bit of the first >> byte before assuming this could be a load option structure, >> however, is too weak a check for my taste. > > There is

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Tamas K Lengyel
On Thu, Jan 4, 2018 at 3:43 AM, Jan Beulich wrote: On 03.01.18 at 17:53, wrote: >> On Wed, Jan 3, 2018 at 9:36 AM, Jan Beulich wrote: >> On 03.01.18 at 17:04, wrote: On Wed, Jan 3, 2018 at 4:20 AM,

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-04 Thread Jan Beulich
>>> On 03.01.18 at 17:53, wrote: > On Wed, Jan 3, 2018 at 9:36 AM, Jan Beulich wrote: > On 03.01.18 at 17:04, wrote: >>> On Wed, Jan 3, 2018 at 4:20 AM, Jan Beulich wrote: >>> On 02.01.18 at 16:56,

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-03 Thread Tamas K Lengyel
On Wed, Jan 3, 2018 at 9:36 AM, Jan Beulich wrote: On 03.01.18 at 17:04, wrote: >> On Wed, Jan 3, 2018 at 4:20 AM, Jan Beulich wrote: >> On 02.01.18 at 16:56, wrote: +if ( elo->Attributes &

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-03 Thread Jan Beulich
>>> On 03.01.18 at 17:04, wrote: > On Wed, Jan 3, 2018 at 4:20 AM, Jan Beulich wrote: > On 02.01.18 at 16:56, wrote: >>> +if ( elo->Attributes & LOAD_OPTION_ACTIVE ) >> >> Without any other (earlier) check, how can you

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-03 Thread Tamas K Lengyel
On Wed, Jan 3, 2018 at 4:20 AM, Jan Beulich wrote: On 02.01.18 at 16:56, wrote: >> When booting Xen via UEFI the Xen config file can contain multiple sections >> each describing different boot options. It is currently only possible to >> choose >>

Re: [Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-03 Thread Jan Beulich
>>> On 02.01.18 at 16:56, wrote: > When booting Xen via UEFI the Xen config file can contain multiple sections > each describing different boot options. It is currently only possible to > choose > which section to boot with if Xen is started through an EFI Shell. Is this

[Xen-devel] [PATCH] xen: Add EFI_LOAD_OPTION support

2018-01-02 Thread Tamas K Lengyel
When booting Xen via UEFI the Xen config file can contain multiple sections each describing different boot options. It is currently only possible to choose which section to boot with if Xen is started through an EFI Shell. As UEFI provides a standard to pass optional arguments to an application in