Re: [Xen-devel] [PATCH 01/17] xen/x86: Introduce helpers to generate/convert the CR3 from/to a MFN/GFN

2020-03-30 Thread Jan Beulich
On 28.03.2020 11:14, Julien Grall wrote: > On 25/03/2020 14:46, Jan Beulich wrote: >> On 22.03.2020 17:14, jul...@xen.org wrote: >>> From: Julien Grall >>> >>> Introduce handy helpers to generate/convert the CR3 from/to a MFN/GFN. >>> >>> Note that we are using cr3_pa() rather than xen_cr3_to_pfn(

Re: [Xen-devel] [PATCH 01/17] xen/x86: Introduce helpers to generate/convert the CR3 from/to a MFN/GFN

2020-03-28 Thread Julien Grall
Hi Jan, On 25/03/2020 14:46, Jan Beulich wrote: On 22.03.2020 17:14, jul...@xen.org wrote: From: Julien Grall Introduce handy helpers to generate/convert the CR3 from/to a MFN/GFN. Note that we are using cr3_pa() rather than xen_cr3_to_pfn() because the latter does not ignore the top 12-bits

Re: [Xen-devel] [PATCH 01/17] xen/x86: Introduce helpers to generate/convert the CR3 from/to a MFN/GFN

2020-03-25 Thread Jan Beulich
On 22.03.2020 17:14, jul...@xen.org wrote: > From: Julien Grall > > Introduce handy helpers to generate/convert the CR3 from/to a MFN/GFN. > > Note that we are using cr3_pa() rather than xen_cr3_to_pfn() because the > latter does not ignore the top 12-bits. I'm afraid this remark of yours point

[Xen-devel] [PATCH 01/17] xen/x86: Introduce helpers to generate/convert the CR3 from/to a MFN/GFN

2020-03-22 Thread julien
From: Julien Grall Introduce handy helpers to generate/convert the CR3 from/to a MFN/GFN. Note that we are using cr3_pa() rather than xen_cr3_to_pfn() because the latter does not ignore the top 12-bits. Take the opportunity to use the new helpers when possible. Signed-off-by: Julien Grall ---