Re: [Xen-devel] [PATCH 05/11] x86/emul: Unfold %cr4.de handling in x86emul_read_dr()

2018-06-08 Thread Jan Beulich
>>> On 08.06.18 at 18:03, wrote: > On 06/06/18 15:20, Jan Beulich wrote: > On 04.06.18 at 15:59, wrote: >>> No functional change (as curr->arch.debugreg[5] is zero when DE is clear), > but >>> this change simplifies the following patch. >> A comment to this effect would be helpful ... >>

Re: [Xen-devel] [PATCH 05/11] x86/emul: Unfold %cr4.de handling in x86emul_read_dr()

2018-06-08 Thread Andrew Cooper
On 06/06/18 15:20, Jan Beulich wrote: On 04.06.18 at 15:59, wrote: >> No functional change (as curr->arch.debugreg[5] is zero when DE is clear), >> but >> this change simplifies the following patch. > A comment to this effect would be helpful ... > >> --- a/xen/arch/x86/x86_emulate.c >> +++

Re: [Xen-devel] [PATCH 05/11] x86/emul: Unfold %cr4.de handling in x86emul_read_dr()

2018-06-06 Thread Roger Pau Monné
On Mon, Jun 04, 2018 at 02:59:09PM +0100, Andrew Cooper wrote: > No functional change (as curr->arch.debugreg[5] is zero when DE is clear), but > this change simplifies the following patch. > > Signed-off-by: Andrew Cooper Reviewed-by: Roger Pau Monné

Re: [Xen-devel] [PATCH 05/11] x86/emul: Unfold %cr4.de handling in x86emul_read_dr()

2018-06-06 Thread Jan Beulich
>>> On 04.06.18 at 15:59, wrote: > No functional change (as curr->arch.debugreg[5] is zero when DE is clear), but > this change simplifies the following patch. A comment to this effect would be helpful ... > --- a/xen/arch/x86/x86_emulate.c > +++ b/xen/arch/x86/x86_emulate.c > @@ -101,23

[Xen-devel] [PATCH 05/11] x86/emul: Unfold %cr4.de handling in x86emul_read_dr()

2018-06-04 Thread Andrew Cooper
No functional change (as curr->arch.debugreg[5] is zero when DE is clear), but this change simplifies the following patch. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Wei Liu CC: Roger Pau Monné --- xen/arch/x86/x86_emulate.c | 24 +++- 1 file changed, 15