Re: [Xen-devel] [PATCH 06/11] x86: Reorganise and rename debug register fields in struct vcpu

2018-06-07 Thread Jan Beulich
>>> On 06.06.18 at 17:21, wrote: > On 06/06/18 16:00, Jan Beulich wrote: > On 04.06.18 at 15:59, wrote: >>> @@ -518,7 +524,10 @@ struct arch_vcpu >>> void *fpu_ctxt; >>> unsigned long vgc_flags; >>> struct cpu_user_regs user_regs; >>> -unsigned long

Re: [Xen-devel] [PATCH 06/11] x86: Reorganise and rename debug register fields in struct vcpu

2018-06-06 Thread Roger Pau Monné
On Mon, Jun 04, 2018 at 02:59:10PM +0100, Andrew Cooper wrote: > Reusing debugreg[5] for the PV emulated IO breakpoint information is confusing > to read. Instead, introduce a dr7_emul field in pv_vcpu for the pupose. > > With the PV emulation out of the way, debugreg[4,5] are entirely unused

Re: [Xen-devel] [PATCH 06/11] x86: Reorganise and rename debug register fields in struct vcpu

2018-06-06 Thread Andrew Cooper
On 06/06/18 16:00, Jan Beulich wrote: On 04.06.18 at 15:59, wrote: >> @@ -981,9 +981,14 @@ int arch_set_info_guest( >> v->arch.pv_vcpu.ctrlreg[4] = cr4 ? pv_guest_cr4_fixup(v, cr4) : >> real_cr4_to_pv_guest_cr4(mmu_cr4_features); >> >> -memset(v->arch.debugreg, 0,

Re: [Xen-devel] [PATCH 06/11] x86: Reorganise and rename debug register fields in struct vcpu

2018-06-06 Thread Jan Beulich
>>> On 04.06.18 at 15:59, wrote: > @@ -981,9 +981,14 @@ int arch_set_info_guest( > v->arch.pv_vcpu.ctrlreg[4] = cr4 ? pv_guest_cr4_fixup(v, cr4) : > real_cr4_to_pv_guest_cr4(mmu_cr4_features); > > -memset(v->arch.debugreg, 0, sizeof(v->arch.debugreg)); > -for ( i = 0; i <

[Xen-devel] [PATCH 06/11] x86: Reorganise and rename debug register fields in struct vcpu

2018-06-04 Thread Andrew Cooper
Reusing debugreg[5] for the PV emulated IO breakpoint information is confusing to read. Instead, introduce a dr7_emul field in pv_vcpu for the pupose. With the PV emulation out of the way, debugreg[4,5] are entirely unused and don't need to be stored. Rename debugreg[0..3] to dr[0..3] to reduce