Re: [Xen-devel] [PATCH 1/2] amd-iommu: use a bitfield for PTE/PDE

2019-02-13 Thread Paul Durrant
uravee ; Roger Pau Monne > > Subject: Re: [Xen-devel] [PATCH 1/2] amd-iommu: use a bitfield for PTE/PDE > > On 2/13/19 3:45 AM, Paul Durrant wrote: > >> -Original Message- > >> From: Woods, Brian [mailto:brian.wo...@amd.com] > >> Sent: 12 February 2019

Re: [Xen-devel] [PATCH 1/2] amd-iommu: use a bitfield for PTE/PDE

2019-02-13 Thread Woods, Brian
On 2/13/19 3:45 AM, Paul Durrant wrote: >> -Original Message- >> From: Woods, Brian [mailto:brian.wo...@amd.com] >> Sent: 12 February 2019 20:14 >> To: Paul Durrant ; xen-devel@lists.xenproject.org >> Cc: Suthikulpanit, Suravee ; Jan Beulich >> ; Andrew Cooper ; Wei Liu >> ; Roger Pau Monne

Re: [Xen-devel] [PATCH 1/2] amd-iommu: use a bitfield for PTE/PDE

2019-02-13 Thread Paul Durrant
> -Original Message- > From: Woods, Brian [mailto:brian.wo...@amd.com] > Sent: 12 February 2019 20:14 > To: Paul Durrant ; xen-devel@lists.xenproject.org > Cc: Suthikulpanit, Suravee ; Jan Beulich > ; Andrew Cooper ; Wei Liu > ; Roger Pau Monne > Subject: Re: [PATCH 1/2] amd-iommu: use a b

Re: [Xen-devel] [PATCH 1/2] amd-iommu: use a bitfield for PTE/PDE

2019-02-12 Thread Woods, Brian
On 2/4/19 5:19 AM, Paul Durrant wrote: > The current use of get/set_field_from/in_reg_u32() is both inefficient and > requires some ugly casting. > > This patch defines a new bitfield structure (amd_iommu_pte) and uses this > structure in all PTE/PDE manipulation, resulting in much more readable >

[Xen-devel] [PATCH 1/2] amd-iommu: use a bitfield for PTE/PDE

2019-02-04 Thread Paul Durrant
The current use of get/set_field_from/in_reg_u32() is both inefficient and requires some ugly casting. This patch defines a new bitfield structure (amd_iommu_pte) and uses this structure in all PTE/PDE manipulation, resulting in much more readable and compact code. NOTE: This commit also fixes on