Re: [Xen-devel] [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can only be set once

2018-10-08 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 08 October 2018 14:20 > To: Paul Durrant > Cc: Andrew Cooper ; Wei Liu > ; xen-devel > Subject: Re: [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can > only be set once > > >>> On 05.10.18 at 15:43,

Re: [Xen-devel] [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can only be set once

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 15:43, wrote: > These parameters should have always been in the 'set once' category > but this has, so far, not been enforced. Hmm, now that I'm looking at patch 2 I see where this is coming from, but a hint towards this here would have helped, if this is to be a separate

Re: [Xen-devel] [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can only be set once

2018-10-08 Thread Jan Beulich
>>> On 05.10.18 at 15:43, wrote: > These parameters should have always been in the 'set once' category > but this has, so far, not been enforced. But now that we're not even handling these anymore, why is there a need to start doing so? If anything wouldn't it be better to add them to the

[Xen-devel] [PATCH 1/2] x86/hvm: make sure HVM_PARAM_[BUF]IOREQ_PFN can only be set once

2018-10-05 Thread Paul Durrant
These parameters should have always been in the 'set once' category but this has, so far, not been enforced. Signed-off-by: Paul Durrant --- Cc: Jan Beulich Cc: Andrew Cooper Cc: Wei Liu --- xen/arch/x86/hvm/hvm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/arch/x86/hvm/hvm.c