Re: [Xen-devel] [PATCH 1/3] x86/ACPI: re-park previously parked CPUs upon resume from S3

2019-08-29 Thread Andrew Cooper
On 14/06/2019 12:37, Jan Beulich wrote: > Aiui when resuming from S3, CPUs come back out of RESET/INIT. From a programmers point of view, all APs are in Wait-for-SIPI after resume, and this is confirmed by several of the BWG flowcharts.  This is a logical consequence of the CPU losing all power,

Re: [Xen-devel] [PATCH 1/3] x86/ACPI: re-park previously parked CPUs upon resume from S3

2019-06-17 Thread Julien Grall
Hi Jan, On 6/17/19 7:40 AM, Jan Beulich wrote: On 14.06.19 at 18:52, wrote: The title and commit message are a bit odd to read because you are modifying common code but everything is geared towards x86. Indeed. There's no caller of {en,dis}able_nonboot_cpus() in Arm code at present, afaics.

Re: [Xen-devel] [PATCH 1/3] x86/ACPI: re-park previously parked CPUs upon resume from S3

2019-06-17 Thread Jan Beulich
>>> On 14.06.19 at 18:52, wrote: > The title and commit message are a bit odd to read because you are modifying > common code but everything is geared towards x86. Indeed. There's no caller of {en,dis}able_nonboot_cpus() in Arm code at present, afaics. Hence the code changed (but not the file)

Re: [Xen-devel] [PATCH 1/3] x86/ACPI: re-park previously parked CPUs upon resume from S3

2019-06-14 Thread Julien Grall
Hi Jan, The title and commit message are a bit odd to read because you are modifying common code but everything is geared towards x86. On 14/06/2019 12:37, Jan Beulich wrote: Aiui when resuming from S3, CPUs come back out of RESET/INIT. Therefore they need to undergo the same procedure as

[Xen-devel] [PATCH 1/3] x86/ACPI: re-park previously parked CPUs upon resume from S3

2019-06-14 Thread Jan Beulich
Aiui when resuming from S3, CPUs come back out of RESET/INIT. Therefore they need to undergo the same procedure as was added elsewhere by commits d8f974f1a6 ("x86: command line option to avoid use of secondary hyper-threads") and 8797d20a6e ("x86: possibly bring up all CPUs even if not all are