Re: [Xen-devel] [PATCH 1/3] x86/spec-ctrl: add AMD SSBD LS_CFG in init print

2018-08-02 Thread Jan Beulich
>>> On 01.08.18 at 23:38, wrote: > On Tue, Jul 31, 2018 at 04:47:48AM -0600, Jan Beulich wrote: >> Why log the same string twice? Simply OR together both conditions. >> Also please don't omit the blank before the ? operator. Both remarks >> apply as well further down. > > Because they're

Re: [Xen-devel] [PATCH 1/3] x86/spec-ctrl: add AMD SSBD LS_CFG in init print

2018-08-01 Thread Brian Woods
On Tue, Jul 31, 2018 at 04:47:48AM -0600, Jan Beulich wrote: > Pointless initializer. Noted > Why log the same string twice? Simply OR together both conditions. > Also please don't omit the blank before the ? operator. Both remarks > apply as well further down. Because they're completely

Re: [Xen-devel] [PATCH 1/3] x86/spec-ctrl: add AMD SSBD LS_CFG in init print

2018-07-31 Thread Jan Beulich
>>> On 20.07.18 at 16:57, wrote: > Edit the initialization code for AMD's SSBD via the LS_CFG MSR and > enable it to pass the status to the initial spec-ctrl print_details at > boot. > > Signed-off-by: Brian Woods > --- > xen/arch/x86/cpu/amd.c| 13 ++--- >

[Xen-devel] [PATCH 1/3] x86/spec-ctrl: add AMD SSBD LS_CFG in init print

2018-07-20 Thread Brian Woods
Edit the initialization code for AMD's SSBD via the LS_CFG MSR and enable it to pass the status to the initial spec-ctrl print_details at boot. Signed-off-by: Brian Woods --- xen/arch/x86/cpu/amd.c| 13 ++--- xen/arch/x86/spec_ctrl.c | 9 +++--