Re: [Xen-devel] [PATCH 1/4] firmware/shim: correctly handle errors during Xen tree setup

2018-02-08 Thread Wei Liu
On Wed, Feb 07, 2018 at 08:07:01AM -0700, Jan Beulich wrote: > "set -e" on a separate Makefile line is meaningless. Glue together all > the lines that this is supposed to cover. > > Signed-off-by: Jan Beulich Reviewed-by: Wei Liu

[Xen-devel] [PATCH 1/4] firmware/shim: correctly handle errors during Xen tree setup

2018-02-07 Thread Jan Beulich
"set -e" on a separate Makefile line is meaningless. Glue together all the lines that this is supposed to cover. Signed-off-by: Jan Beulich --- a/tools/firmware/xen-dir/Makefile +++ b/tools/firmware/xen-dir/Makefile @@ -16,18 +16,18 @@ DEP_FILES=$(foreach i, $(LINK_FILES), $(