Re: [Xen-devel] [PATCH 1/4] x86/svm: Clean up construct_vmcb()

2019-12-04 Thread Andrew Cooper
On 04/12/2019 10:06, Jan Beulich wrote: > On 04.12.2019 10:43, Andrew Cooper wrote: >> The vmcb is zeroed on allocate - drop all explicit writes of 0. Move >> hvm_update_guest_efer() to co-locate it with the other control register >> updates. >> >> Move the BUILD_BUG_ON() into build_assertions(),

Re: [Xen-devel] [PATCH 1/4] x86/svm: Clean up construct_vmcb()

2019-12-04 Thread Jan Beulich
On 04.12.2019 10:43, Andrew Cooper wrote: > The vmcb is zeroed on allocate - drop all explicit writes of 0. Move > hvm_update_guest_efer() to co-locate it with the other control register > updates. > > Move the BUILD_BUG_ON() into build_assertions(), and add some offset checks > for fields after

[Xen-devel] [PATCH 1/4] x86/svm: Clean up construct_vmcb()

2019-12-04 Thread Andrew Cooper
The vmcb is zeroed on allocate - drop all explicit writes of 0. Move hvm_update_guest_efer() to co-locate it with the other control register updates. Move the BUILD_BUG_ON() into build_assertions(), and add some offset checks for fields after the large blocks of reserved fields (as these are the