Re: [Xen-devel] [PATCH 2/2] AMD/IOMMU: Render IO_PAGE_FAULT errors in a more useful manner

2019-11-27 Thread Andrew Cooper
On 27/11/2019 09:40, Roger Pau Monné wrote: > On Tue, Nov 26, 2019 at 03:01:12PM +, Andrew Cooper wrote: >> Print the PCI coordinates in its common format and use d%u notation for the >> domain. As well as printing flags, decode them. IO_PAGE_FAULT is used for >> interrupt remapping errors

Re: [Xen-devel] [PATCH 2/2] AMD/IOMMU: Render IO_PAGE_FAULT errors in a more useful manner

2019-11-27 Thread Andrew Cooper
On 27/11/2019 17:02, Jan Beulich wrote: > On 26.11.2019 16:01, Andrew Cooper wrote: >> @@ -560,18 +557,26 @@ static void parse_event_log_entry(struct amd_iommu >> *iommu, u32 entry[]) >> >> if ( code == IOMMU_EVENT_IO_PAGE_FAULT ) >> { >> -device_id =

Re: [Xen-devel] [PATCH 2/2] AMD/IOMMU: Render IO_PAGE_FAULT errors in a more useful manner

2019-11-27 Thread Jan Beulich
On 26.11.2019 16:01, Andrew Cooper wrote: > @@ -560,18 +557,26 @@ static void parse_event_log_entry(struct amd_iommu > *iommu, u32 entry[]) > > if ( code == IOMMU_EVENT_IO_PAGE_FAULT ) > { > -device_id = iommu_get_devid_from_event(entry[0]); > -domain_id =

Re: [Xen-devel] [PATCH 2/2] AMD/IOMMU: Render IO_PAGE_FAULT errors in a more useful manner

2019-11-27 Thread Roger Pau Monné
On Tue, Nov 26, 2019 at 03:01:12PM +, Andrew Cooper wrote: > Print the PCI coordinates in its common format and use d%u notation for the > domain. As well as printing flags, decode them. IO_PAGE_FAULT is used for > interrupt remapping errors as well as DMA remapping errors. > > Before: >

[Xen-devel] [PATCH 2/2] AMD/IOMMU: Render IO_PAGE_FAULT errors in a more useful manner

2019-11-26 Thread Andrew Cooper
Print the PCI coordinates in its common format and use d%u notation for the domain. As well as printing flags, decode them. IO_PAGE_FAULT is used for interrupt remapping errors as well as DMA remapping errors. Before: (XEN) AMD-Vi: IO_PAGE_FAULT: domain = 0, device id = 0xa1, fault address =