Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-18 Thread Sander Eikelenboom
On 18/10/2019 18:11, Anthony PERARD wrote: > On Mon, Oct 14, 2019 at 11:03:43PM +0800, Chao Gao wrote: >> On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >>> Hi Anthony / Chao, >>> >>> I have to come back to this, a bit because perhaps there is an underlying >>> issue. >>>

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-18 Thread Anthony PERARD
On Mon, Oct 14, 2019 at 11:03:43PM +0800, Chao Gao wrote: > On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: > >Hi Anthony / Chao, > > > >I have to come back to this, a bit because perhaps there is an underlying > >issue. > >While it earlier occurred to me that the VM to which

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-15 Thread Chao Gao
On Tue, Oct 15, 2019 at 06:59:37PM +0200, Sander Eikelenboom wrote: >On 14/10/2019 17:03, Chao Gao wrote: >> On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >>> On 01/10/2019 12:35, Anthony PERARD wrote: Rewrite of the commit message: Before the problematic

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-15 Thread Sander Eikelenboom
On 15/10/2019 18:59, Sander Eikelenboom wrote: > On 14/10/2019 17:03, Chao Gao wrote: >> On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >>> On 01/10/2019 12:35, Anthony PERARD wrote: Rewrite of the commit message: Before the problematic commit, libxl used to

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-15 Thread Sander Eikelenboom
On 14/10/2019 17:03, Chao Gao wrote: > On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >> On 01/10/2019 12:35, Anthony PERARD wrote: >>> Rewrite of the commit message: >>> >>> Before the problematic commit, libxl used to ignore error when >>> destroying (force == true) a

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-14 Thread Chao Gao
On Thu, Oct 10, 2019 at 06:13:43PM +0200, Sander Eikelenboom wrote: >On 01/10/2019 12:35, Anthony PERARD wrote: >> Rewrite of the commit message: >> >> Before the problematic commit, libxl used to ignore error when >> destroying (force == true) a passthrough device, especially error that >>

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-10 Thread Sander Eikelenboom
On 01/10/2019 12:35, Anthony PERARD wrote: > Rewrite of the commit message: > > Before the problematic commit, libxl used to ignore error when > destroying (force == true) a passthrough device, especially error that > happens when dealing with the DM. > > Since fae4880c45fe, if the DM failed to

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-10-01 Thread Anthony PERARD
Rewrite of the commit message: Before the problematic commit, libxl used to ignore error when destroying (force == true) a passthrough device, especially error that happens when dealing with the DM. Since fae4880c45fe, if the DM failed to detach the pci device within the allowed time, the timed

Re: [Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-09-30 Thread Sander Eikelenboom
On 30/09/2019 19:23, Anthony PERARD wrote: > Before the problematic commit, libxl used to ignore error when > destroying (force == true) a passthrough device. If the DM failed to > detach the pci device within the allowed time, the timed out error > raised skip part of pci_remove_*, but also raise

[Xen-devel] [PATCH 2/2] libxl_pci: Fix guest shutdown with PCI PT attached

2019-09-30 Thread Anthony PERARD
Before the problematic commit, libxl used to ignore error when destroying (force == true) a passthrough device. If the DM failed to detach the pci device within the allowed time, the timed out error raised skip part of pci_remove_*, but also raise the error up to the caller of