Re: [Xen-devel] [PATCH 2/2] vpci/msi: fix update of bound MSI interrupts

>>> On 14.05.18 at 16:27, wrote: > On Mon, May 14, 2018 at 06:29:37AM -0600, Jan Beulich wrote: >> >>> On 08.05.18 at 11:25, wrote: >> > --- a/xen/arch/x86/hvm/vmsi.c >> > +++ b/xen/arch/x86/hvm/vmsi.c >> > @@ -699,6 +699,29 @@ static int

Re: [Xen-devel] [PATCH 2/2] vpci/msi: fix update of bound MSI interrupts

On Mon, May 14, 2018 at 06:29:37AM -0600, Jan Beulich wrote: > >>> On 08.05.18 at 11:25, wrote: > > --- a/xen/arch/x86/hvm/vmsi.c > > +++ b/xen/arch/x86/hvm/vmsi.c > > @@ -699,6 +699,29 @@ static int vpci_msi_update(const struct pci_dev *pdev, > > uint32_t data, > >

[Xen-devel] [PATCH 2/2] vpci/msi: fix update of bound MSI interrupts

Current update process of already bound MSI interrupts is wrong because unmap_domain_pirq calls pci_disable_msi, which disables MSI interrupts on the device. On the other hand map_domain_pirq doesn't enable MSI, so the current update process of already enabled MSI entries is wrong because MSI