Re: [Xen-devel] [PATCH 2/2] x86emul: slightly alter AVX512 exception checking conditionals

2018-12-10 Thread Jan Beulich
>>> On 10.12.18 at 15:00, wrote: > On 07/12/2018 11:18, Jan Beulich wrote: >> While actually benign (operands are either register or memory ones >> anyway), I think it is better to use != instead of == for such checks. >> >> Signed-off-by: Jan Beulich > > I don't see the point of making this

Re: [Xen-devel] [PATCH 2/2] x86emul: slightly alter AVX512 exception checking conditionals

2018-12-10 Thread Andrew Cooper
On 07/12/2018 11:18, Jan Beulich wrote: > While actually benign (operands are either register or memory ones > anyway), I think it is better to use != instead of == for such checks. > > Signed-off-by: Jan Beulich I don't see the point of making this change.  Code is easier to follow when there

[Xen-devel] [PATCH 2/2] x86emul: slightly alter AVX512 exception checking conditionals

2018-12-07 Thread Jan Beulich
While actually benign (operands are either register or memory ones anyway), I think it is better to use != instead of == for such checks. Signed-off-by: Jan Beulich --- a/xen/arch/x86/x86_emulate/x86_emulate.c +++ b/xen/arch/x86/x86_emulate/x86_emulate.c @@ -5918,11 +5918,11 @@ x86_emulate(