Re: [Xen-devel] [PATCH 2/3] libxl: Improve logging in libxl__build_dom()

2018-02-09 Thread Roger Pau Monné
On Thu, Feb 08, 2018 at 10:49:09PM +0100, Simon Gaiser wrote: > xc_dom_parse_image() does not set errno (at least in many code paths). > So LOGE() is not useful. IIRC the expectation is that libxc functions will return -1 on failure and set errno. This is however far from true, so: > Signed-off-b

[Xen-devel] [PATCH 2/3] libxl: Improve logging in libxl__build_dom()

2018-02-08 Thread Simon Gaiser
xc_dom_parse_image() does not set errno (at least in many code paths). So LOGE() is not useful. Signed-off-by: Simon Gaiser --- tools/libxl/libxl_dom.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libxl/libxl_dom.c b/tools/libxl/libxl_dom.c index ef834e652d..52b61379