Re: [Xen-devel] [PATCH 2/3] string: remove memscan()

2019-01-07 Thread Juergen Gross
On 07/01/2019 10:39, Jan Beulich wrote: > It has no users, so rather than fixing its use of types (first and > foremost c would need to be cast to unsigned char in the comparison > expression) drop it altogether. memchr() ought to be fine for all > purposes. > > Take the opportunity and also do

[Xen-devel] [PATCH 2/3] string: remove memscan()

2019-01-07 Thread Jan Beulich
It has no users, so rather than fixing its use of types (first and foremost c would need to be cast to unsigned char in the comparison expression) drop it altogether. memchr() ought to be fine for all purposes. Take the opportunity and also do some stylistic adjustments to its surviving sibling