Re: [Xen-devel] [PATCH 2/3] x86/pvh: Fixes to convert_pvh_info()

2019-01-30 Thread Jan Beulich
>>> On 29.01.19 at 21:43, wrote: > On 23/01/2019 11:35, Jan Beulich wrote: > On 21.01.19 at 16:37, wrote: >>> --- a/xen/arch/x86/guest/pvh-boot.c >>> +++ b/xen/arch/x86/guest/pvh-boot.c >>> @@ -38,12 +38,20 @@ static const char *__initdata pvh_loader = "PVH > Directboot"; >>> static void

Re: [Xen-devel] [PATCH 2/3] x86/pvh: Fixes to convert_pvh_info()

2019-01-29 Thread Andrew Cooper
On 23/01/2019 11:35, Jan Beulich wrote: On 21.01.19 at 16:37, wrote: >> --- a/xen/arch/x86/guest/pvh-boot.c >> +++ b/xen/arch/x86/guest/pvh-boot.c >> @@ -38,12 +38,20 @@ static const char *__initdata pvh_loader = "PVH >> Directboot"; >> static void __init convert_pvh_info(multiboot_info_t

Re: [Xen-devel] [PATCH 2/3] x86/pvh: Fixes to convert_pvh_info()

2019-01-23 Thread Jan Beulich
>>> On 21.01.19 at 16:37, wrote: > --- a/xen/arch/x86/guest/pvh-boot.c > +++ b/xen/arch/x86/guest/pvh-boot.c > @@ -38,12 +38,20 @@ static const char *__initdata pvh_loader = "PVH > Directboot"; > static void __init convert_pvh_info(multiboot_info_t **mbi, >

Re: [Xen-devel] [PATCH 2/3] x86/pvh: Fixes to convert_pvh_info()

2019-01-21 Thread Andrew Cooper
On 21/01/2019 15:52, Wei Liu wrote: > On Mon, Jan 21, 2019 at 03:37:20PM +, Andrew Cooper wrote: >> panic() doesn't contain any caller information, so the sum output of: >> >> (d1) (XEN) >> (d1) (XEN) >> (d1) (XEN) Panic on CPU 0: >> (d1) (XEN)

Re: [Xen-devel] [PATCH 2/3] x86/pvh: Fixes to convert_pvh_info()

2019-01-21 Thread Wei Liu
On Mon, Jan 21, 2019 at 03:37:20PM +, Andrew Cooper wrote: > panic() doesn't contain any caller information, so the sum output of: > > (d1) (XEN) > (d1) (XEN) > (d1) (XEN) Panic on CPU 0: > (d1) (XEN) Magic value is wrong: 336ec568 > (d1)

[Xen-devel] [PATCH 2/3] x86/pvh: Fixes to convert_pvh_info()

2019-01-21 Thread Andrew Cooper
panic() doesn't contain any caller information, so the sum output of: (d1) (XEN) (d1) (XEN) (d1) (XEN) Panic on CPU 0: (d1) (XEN) Magic value is wrong: 336ec568 (d1) (XEN) (d1) (XEN) isn't helpful at