Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-13 Thread Andrew Cooper
On 13/12/2019 13:58, George Dunlap wrote: > >> On Dec 12, 2019, at 7:57 PM, Andrew Cooper wrote: >> >> On 12/12/2019 17:32, George Dunlap wrote: >>> Both put_page_from_l2e and put_page_from_l3e handle having superpage >>> entries by looping over each page and "put"-ing each one individually. >>>

Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-13 Thread George Dunlap
> On Dec 12, 2019, at 7:57 PM, Andrew Cooper wrote: > > On 12/12/2019 17:32, George Dunlap wrote: >> Both put_page_from_l2e and put_page_from_l3e handle having superpage >> entries by looping over each page and "put"-ing each one individually. >> As with putting page table entries, this code

Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-13 Thread Jan Beulich
On 12.12.2019 18:32, George Dunlap wrote: > Both put_page_from_l2e and put_page_from_l3e handle having superpage > entries by looping over each page and "put"-ing each one individually. > As with putting page table entries, this code is functionally > identical, but for some reason different.

Re: [Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-12 Thread Andrew Cooper
On 12/12/2019 17:32, George Dunlap wrote: > Both put_page_from_l2e and put_page_from_l3e handle having superpage > entries by looping over each page and "put"-ing each one individually. > As with putting page table entries, this code is functionally > identical, but for some reason different.

[Xen-devel] [PATCH 2/4] x86/mm: Implement common put_data_pages for put_page_from_l[23]e

2019-12-12 Thread George Dunlap
Both put_page_from_l2e and put_page_from_l3e handle having superpage entries by looping over each page and "put"-ing each one individually. As with putting page table entries, this code is functionally identical, but for some reason different. Moreover, there is already a common function,