Re: [Xen-devel] [PATCH 24/24] golang/xenlight: add make target for generated files

2019-11-14 Thread George Dunlap
On 10/24/19 7:49 PM, Nick Rosbrook wrote: >> One standard practice when making a series is to try to avoid any >> regressions, including build regressions, in the middle of the series. >> This is particularly helpful to aid in bisections, but in this case it >> makes it easier to observe the

Re: [Xen-devel] [PATCH 24/24] golang/xenlight: add make target for generated files

2019-10-24 Thread Nick Rosbrook
> One standard practice when making a series is to try to avoid any > regressions, including build regressions, in the middle of the series. > This is particularly helpful to aid in bisections, but in this case it > makes it easier to observe the action of the `gengotypes.py` script (and > how

Re: [Xen-devel] [PATCH 24/24] golang/xenlight: add make target for generated files

2019-10-24 Thread George Dunlap
On 10/7/19 4:13 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Remove the PKGSOURCES variable since adding xenlight_types.go > and xenlight_helpers.go to this list breaks the rest of the > Makefile. > > Add xenlight_%.go target for generated files, and use full > file names within install,

[Xen-devel] [PATCH 24/24] golang/xenlight: add make target for generated files

2019-10-07 Thread Nick Rosbrook
From: Nick Rosbrook Remove the PKGSOURCES variable since adding xenlight_types.go and xenlight_helpers.go to this list breaks the rest of the Makefile. Add xenlight_%.go target for generated files, and use full file names within install, uninstall and $(XEN_GOPATH)$(GOXL_PKG_DIR) rule.