Re: [Xen-devel] [PATCH 3/3] x86/PV: polish pv_set_gdt()

2019-12-06 Thread Andrew Cooper
On 06/12/2019 10:15, Jan Beulich wrote: > There's no need to invoke get_page_from_gfn(), and there's also no need > to update the passed in frames[]. Invoke get_page_and_type() directly. > > Also make the function's frames[] parameter const, change its return > type to int, and drop the bogus

[Xen-devel] [PATCH 3/3] x86/PV: polish pv_set_gdt()

2019-12-06 Thread Jan Beulich
There's no need to invoke get_page_from_gfn(), and there's also no need to update the passed in frames[]. Invoke get_page_and_type() directly. Also make the function's frames[] parameter const, change its return type to int, and drop the bogus casts from two of its invocations. Finally a little