Re: [Xen-devel] [PATCH 3/4] x86/svm: Clean up intinfo_t variables

2019-12-05 Thread Andrew Cooper
On 04/12/2019 09:43, Andrew Cooper wrote: > The type name is poor because the type is also used for the IDT vectoring > field, not just for the event injection field. Rename it to intinfo_t which > is how the APM refers to the data. > > Rearrange the union to drop the .fields infix, and rename

Re: [Xen-devel] [PATCH 3/4] x86/svm: Clean up intinfo_t variables

2019-12-05 Thread Jan Beulich
On 04.12.2019 20:38, Andrew Cooper wrote: > On 04/12/2019 09:43, Andrew Cooper wrote: >> @@ -420,10 +420,10 @@ struct vmcb_struct { >> u64 exitcode; /* offset 0x70 */ >> u64 exitinfo1; /* offset 0x78 */ >> u64 exitinfo2; /* offset 0x80 */ >> -

Re: [Xen-devel] [PATCH 3/4] x86/svm: Clean up intinfo_t variables

2019-12-04 Thread Andrew Cooper
On 04/12/2019 09:43, Andrew Cooper wrote: > @@ -420,10 +420,10 @@ struct vmcb_struct { > u64 exitcode; /* offset 0x70 */ > u64 exitinfo1; /* offset 0x78 */ > u64 exitinfo2; /* offset 0x80 */ > -eventinj_t exitintinfo;/* offset 0x88 */

Re: [Xen-devel] [PATCH 3/4] x86/svm: Clean up intinfo_t variables

2019-12-04 Thread Andrew Cooper
On 04/12/2019 10:19, Jan Beulich wrote: > On 04.12.2019 10:43, Andrew Cooper wrote: >> --- a/xen/arch/x86/hvm/svm/intr.c >> +++ b/xen/arch/x86/hvm/svm/intr.c >> @@ -43,15 +43,13 @@ static void svm_inject_nmi(struct vcpu *v) >> { >> struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; >> u32

Re: [Xen-devel] [PATCH 3/4] x86/svm: Clean up intinfo_t variables

2019-12-04 Thread Jan Beulich
On 04.12.2019 10:43, Andrew Cooper wrote: > --- a/xen/arch/x86/hvm/svm/intr.c > +++ b/xen/arch/x86/hvm/svm/intr.c > @@ -43,15 +43,13 @@ static void svm_inject_nmi(struct vcpu *v) > { > struct vmcb_struct *vmcb = v->arch.hvm.svm.vmcb; > u32 general1_intercepts =

[Xen-devel] [PATCH 3/4] x86/svm: Clean up intinfo_t variables

2019-12-04 Thread Andrew Cooper
The type name is poor because the type is also used for the IDT vectoring field, not just for the event injection field. Rename it to intinfo_t which is how the APM refers to the data. Rearrange the union to drop the .fields infix, and rename bytes to the more common raw. While adjusting all