Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-14 Thread Julien Grall
Hi, On 03/14/2018 02:30 PM, Andre Przywara wrote: Hi, On 13/03/18 17:42, Julien Grall wrote: Hi, On 13/03/18 17:34, Andre Przywara wrote: On 13/03/18 17:14, Julien Grall wrote: On 13/03/18 17:02, Andre Przywara wrote: On 08/03/18 15:39, Julien Grall wrote: On 05/03/18 16:03, Andre Przywar

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-14 Thread Andre Przywara
Hi, On 13/03/18 17:42, Julien Grall wrote: > Hi, > > On 13/03/18 17:34, Andre Przywara wrote: >> On 13/03/18 17:14, Julien Grall wrote: >>> On 13/03/18 17:02, Andre Przywara wrote: On 08/03/18 15:39, Julien Grall wrote: > On 05/03/18 16:03, Andre Przywara wrote: >>> I can't see how a kno

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-13 Thread Julien Grall
Hi, On 13/03/18 17:34, Andre Przywara wrote: On 13/03/18 17:14, Julien Grall wrote: On 13/03/18 17:02, Andre Przywara wrote: On 08/03/18 15:39, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: I can't see how a knowledgeable admin will be able to know that IRQ 2 is active with ju

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-13 Thread Andre Przywara
Hi, On 13/03/18 17:14, Julien Grall wrote: > Hi Andre, > > On 13/03/18 17:02, Andre Przywara wrote: >> On 08/03/18 15:39, Julien Grall wrote: >>> On 05/03/18 16:03, Andre Przywara wrote: +/* + * We don't actually support clearing the active state of an IRQ (yet). + * However t

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-13 Thread Julien Grall
On 13/03/18 17:14, Julien Grall wrote: On 13/03/18 17:02, Andre Przywara wrote: On 08/03/18 15:39, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: I admit the bailout is a bit weird here. You would only print the warning for the first activated IRQ and give the impression it is f

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-13 Thread Julien Grall
Hi Andre, On 13/03/18 17:02, Andre Przywara wrote: On 08/03/18 15:39, Julien Grall wrote: On 05/03/18 16:03, Andre Przywara wrote: +/* + * We don't actually support clearing the active state of an IRQ (yet). + * However there is a chance that most guests use this for initialization. + * We che

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-13 Thread Andre Przywara
Hi, On 08/03/18 15:39, Julien Grall wrote: > Hi Andre, > > On 05/03/18 16:03, Andre Przywara wrote: >> The active register handlers are shared between the v2 and v3 emulation, >> so their implementation goes into vgic-mmio.c, to be easily referenced >> from the v3 emulation as well later. >> Sinc

Re: [Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-08 Thread Julien Grall
Hi Andre, On 05/03/18 16:03, Andre Przywara wrote: The active register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. Since activation/deactivation of an interrupt may happen entirel

[Xen-devel] [PATCH 39/57] ARM: new VGIC: Add ACTIVE registers handlers

2018-03-05 Thread Andre Przywara
The active register handlers are shared between the v2 and v3 emulation, so their implementation goes into vgic-mmio.c, to be easily referenced from the v3 emulation as well later. Since activation/deactivation of an interrupt may happen entirely in the guest without it ever exiting, we need some e