Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2020-01-08 Thread Julien Grall
Hi, On 03/01/2020 10:44, Julien Grall wrote: Hi Andrew, On 02/01/2020 17:49, Andrew Cooper wrote: On 23/12/2019 18:23, Julien Grall wrote: Hi, On 17/12/2019 21:15, Andrew Cooper wrote: xc_dom_p2m() and dom->p2m_host[] implement a linear transform for translated domains, but waste a substant

Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2020-01-03 Thread Jan Beulich
On 03.01.2020 16:02, Andrew Cooper wrote: > On 03/01/2020 14:25, Jan Beulich wrote: >> On 17.12.2019 21:15, Andrew Cooper wrote: >>> --- a/tools/libxc/include/xc_dom.h >>> +++ b/tools/libxc/include/xc_dom.h >>> @@ -123,16 +123,12 @@ struct xc_dom_image { >>> >>> /* other state info */ >>>

Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2020-01-03 Thread Andrew Cooper
On 03/01/2020 14:25, Jan Beulich wrote: > On 17.12.2019 21:15, Andrew Cooper wrote: >> --- a/tools/libxc/include/xc_dom.h >> +++ b/tools/libxc/include/xc_dom.h >> @@ -123,16 +123,12 @@ struct xc_dom_image { >> >> /* other state info */ >> uint32_t f_active[XENFEAT_NR_SUBMAPS]; >> + >>

Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2020-01-03 Thread Jan Beulich
On 17.12.2019 21:15, Andrew Cooper wrote: > --- a/tools/libxc/include/xc_dom.h > +++ b/tools/libxc/include/xc_dom.h > @@ -123,16 +123,12 @@ struct xc_dom_image { > > /* other state info */ > uint32_t f_active[XENFEAT_NR_SUBMAPS]; > + > /* > - * p2m_host maps guest physical addr

Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2020-01-03 Thread Julien Grall
Hi Andrew, On 02/01/2020 17:49, Andrew Cooper wrote: On 23/12/2019 18:23, Julien Grall wrote: Hi, On 17/12/2019 21:15, Andrew Cooper wrote: xc_dom_p2m() and dom->p2m_host[] implement a linear transform for translated domains, but waste a substantial chunk of RAM doing so. ARM literally never

Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2020-01-02 Thread Andrew Cooper
On 23/12/2019 18:23, Julien Grall wrote: > Hi, > > On 17/12/2019 21:15, Andrew Cooper wrote: >> xc_dom_p2m() and dom->p2m_host[] implement a linear transform for >> translated >> domains, but waste a substantial chunk of RAM doing so. >> >> ARM literally never reads dom->p2m_host[] (because of the

Re: [Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2019-12-23 Thread Julien Grall
Hi, On 17/12/2019 21:15, Andrew Cooper wrote: xc_dom_p2m() and dom->p2m_host[] implement a linear transform for translated domains, but waste a substantial chunk of RAM doing so. ARM literally never reads dom->p2m_host[] (because of the xc_dom_translated() short circuit in xc_dom_p2m()). Drop

[Xen-devel] [PATCH 4/4] tools/dombuilder: Don't allocate dom->p2m_host[] for translated domains

2019-12-17 Thread Andrew Cooper
xc_dom_p2m() and dom->p2m_host[] implement a linear transform for translated domains, but waste a substantial chunk of RAM doing so. ARM literally never reads dom->p2m_host[] (because of the xc_dom_translated() short circuit in xc_dom_p2m()). Drop it all. x86 HVM does use dom->p2m_host[] for xc_