Re: [Xen-devel] [PATCH 6/6] xen-blkfront: prepare request locally, only then put it on the shared ring

2018-05-01 Thread Roger Pau Monné
On Tue, May 01, 2018 at 09:22:31AM +0100, Roger Pau Monné wrote: > On Mon, Apr 30, 2018 at 11:01:50PM +0200, Marek Marczykowski-Górecki wrote: > > struct request *req, > > - struct blkif_request **ring_req) > > +

Re: [Xen-devel] [PATCH 6/6] xen-blkfront: prepare request locally, only then put it on the shared ring

2018-05-01 Thread Roger Pau Monné
On Mon, Apr 30, 2018 at 11:01:50PM +0200, Marek Marczykowski-Górecki wrote: > Do not reuse data which theoretically might be already modified by the > backend. This is mostly about private copy of the request > (info->shadow[id].req) - make sure the request saved there is really the > one just

[Xen-devel] [PATCH 6/6] xen-blkfront: prepare request locally, only then put it on the shared ring

2018-04-30 Thread Marek Marczykowski-Górecki
Do not reuse data which theoretically might be already modified by the backend. This is mostly about private copy of the request (info->shadow[id].req) - make sure the request saved there is really the one just filled. This is complementary to XSA155. CC: sta...@vger.kernel.org Signed-off-by: