Re: [Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-16 Thread Andrew Cooper
On 16/03/2018 07:43, Jan Beulich wrote: On 15.03.18 at 21:25, wrote: >> On 13/03/18 14:39, Jan Beulich wrote: >> On 13.03.18 at 13:28, wrote: On Fri, Mar 09, 2018 at 01:18:42PM +, Andrew Cooper wrote: > ---

Re: [Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-16 Thread Jan Beulich
>>> On 15.03.18 at 21:25, wrote: > On 13/03/18 14:39, Jan Beulich wrote: > On 13.03.18 at 13:28, wrote: >>> On Fri, Mar 09, 2018 at 01:18:42PM +, Andrew Cooper wrote: --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@

Re: [Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-15 Thread Andrew Cooper
On 13/03/18 14:39, Jan Beulich wrote: On 13.03.18 at 13:28, wrote: >> On Fri, Mar 09, 2018 at 01:18:42PM +, Andrew Cooper wrote: >>> --- a/xen/arch/arm/mm.c >>> +++ b/xen/arch/arm/mm.c >>> @@ -1187,8 +1187,8 @@ unsigned long domain_get_maximum_gpfn(struct domain

Re: [Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-13 Thread Jan Beulich
>>> On 13.03.18 at 13:28, wrote: > On Fri, Mar 09, 2018 at 01:18:42PM +, Andrew Cooper wrote: >> --- a/xen/arch/arm/mm.c >> +++ b/xen/arch/arm/mm.c >> @@ -1187,8 +1187,8 @@ unsigned long domain_get_maximum_gpfn(struct domain *d) >> return

Re: [Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-13 Thread Roger Pau Monné
On Fri, Mar 09, 2018 at 01:18:42PM +, Andrew Cooper wrote: > The share_xen_page_with_guest() functions are used by common code, and are > implemented the same by each arch. Move the declarations into the common mm.h > rather than duplicating them in each arch/mm.h > > Turn an int readonly

Re: [Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-11 Thread Julien Grall
Hi Andrew, On 03/09/2018 01:18 PM, Andrew Cooper wrote: The share_xen_page_with_guest() functions are used by common code, and are implemented the same by each arch. Move the declarations into the common mm.h rather than duplicating them in each arch/mm.h Turn an int readonly into a boolean

Re: [Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-09 Thread Wei Liu
On Fri, Mar 09, 2018 at 01:18:42PM +, Andrew Cooper wrote: > The share_xen_page_with_guest() functions are used by common code, and are > implemented the same by each arch. Move the declarations into the common mm.h > rather than duplicating them in each arch/mm.h > > Turn an int readonly

[Xen-devel] [PATCH 7/7] xen/mm: Clean up share_xen_page_with_guest() API

2018-03-09 Thread Andrew Cooper
The share_xen_page_with_guest() functions are used by common code, and are implemented the same by each arch. Move the declarations into the common mm.h rather than duplicating them in each arch/mm.h Turn an int readonly into a boolean enum, to retain ro/rw context at the callsites, but use