Hi,
On 11/12/18 4:58 PM, Andrii Anisov wrote:
What's wrong with including clean-up patch in a series adding a feature?
I do not mean it is wrong.
Just assuming that introducing a new feature and cleaning up a code
might be different processes with a different review period.
We don't have dif
> What's wrong with including clean-up patch in a series adding a feature?
I do not mean it is wrong.
Just assuming that introducing a new feature and cleaning up a code
might be different processes with a different review period.
Sincerely,
Andrii Anisov.
___
On 11/12/18 4:49 PM, Andrii Anisov wrote:
Hello Julien,
Hi,
I'm just wondering if this patch really belongs to xentrace series.
It rather looks like a separate cleanup patch.
What's wrong with including clean-up patch in a series adding a feature?
Cheers,
--
Julien Grall
_
Hello Julien,
I'm just wondering if this patch really belongs to xentrace series.
It rather looks like a separate cleanup patch.
Sincerely,
Andrii Anisov.
вт, 6 лист. 2018 о 21:16 Julien Grall пише:
> No functional change intended.
>
> Only reasonable clean-ups are done in this patch. The res
On 07/11/18 08:57, Paul Durrant wrote:
>>
>>> static inline struct page_info *get_page_from_gfn(
>>> -struct domain *d, unsigned long gfn, p2m_type_t *t, p2m_query_t q)
>>> +struct domain *d, gfn_t gfn, p2m_type_t *t, p2m_query_t q)
>>> {
>>> struct page_info *page;
>>> +mfn_t mf
Hi Andrew,
On 06/11/2018 20:11, Andrew Cooper wrote:
This looks like it would be cleaner by not splitting mfn out into a
separate variable.
page = mfn_to_page(_mfn(gfn_x(gfn)));
return mfn_valid(mfn) && get_page(page, d) ? page : NULL;
The only reason this looks odd is because of the mfn => g
Hi Paul,
On 07/11/2018 09:24, Paul Durrant wrote:
-Original Message-
From: Julien Grall [mailto:julien.gr...@arm.com]
Sent: 06 November 2018 19:15
To: sstabell...@kernel.org; xen-devel@lists.xenproject.org
Cc: Julien Grall ; Andrew Cooper
; George Dunlap ; Ian
Jackson ; Jan Beulich ; Kon
> -Original Message-
> From: Julien Grall [mailto:julien.gr...@arm.com]
> Sent: 06 November 2018 19:15
> To: sstabell...@kernel.org; xen-devel@lists.xenproject.org
> Cc: Julien Grall ; Andrew Cooper
> ; George Dunlap ; Ian
> Jackson ; Jan Beulich ; Konrad
> Rzeszutek Wilk ; Tim (Xen.org) ;
> -Original Message-
> From: Andrew Cooper
> Sent: 06 November 2018 20:12
> To: Julien Grall ; sstabell...@kernel.org; xen-
> de...@lists.xenproject.org
> Cc: George Dunlap ; Ian Jackson
> ; Jan Beulich ; Konrad
> Rzeszutek Wilk ; Tim (Xen.org) ; Wei
> Liu ; Boris Ostrovsky ;
> Suravee Suth
Hi - just some cosmetic suggestions.
Subject s/Swich/Switch/
> diff --git a/xen/arch/x86/pv/emul-priv-op.c b/xen/arch/x86/pv/emul-priv-op.c
> index f73ea4a163..a529ebcc3f 100644
> --- a/xen/arch/x86/pv/emul-priv-op.c
> +++ b/xen/arch/x86/pv/emul-priv-op.c
> @@ -760,12 +760,12 @@ static int write_
No functional change intended.
Only reasonable clean-ups are done in this patch. The rest will use _gfn
for the time being.
Signed-off-by: Julien Grall
---
xen/arch/arm/guestcopy.c | 2 +-
xen/arch/arm/mm.c| 2 +-
xen/arch/x86/cpu/vpmu.c | 2 +-
x
11 matches
Mail list logo
