Re: [Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-25 Thread Konrad Rzeszutek Wilk
On Wed, Jan 24, 2018 at 03:49:16PM +, Andrew Cooper wrote: > The use of __LINE__ in a printk() is problematic for livepatching, as it > causes unnecessary binary differences. > > Furthermore, diagnostic information around calls is inconsistent and > occasionally unhelpful. (e.g. diagnosing

Re: [Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-24 Thread Andrew Cooper
On 24/01/18 16:46, Jan Beulich wrote: On 24.01.18 at 17:31, wrote: >> On 24/01/18 16:15, Andrew Cooper wrote: >>> On 24/01/18 16:11, Jan Beulich wrote: >>> On 24.01.18 at 16:49, wrote: > --- a/xen/include/xen/sched.h > +++

Re: [Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-24 Thread Jan Beulich
>>> On 24.01.18 at 17:31, wrote: > On 24/01/18 16:15, Andrew Cooper wrote: >> On 24/01/18 16:11, Jan Beulich wrote: >> On 24.01.18 at 16:49, wrote: --- a/xen/include/xen/sched.h +++ b/xen/include/xen/sched.h @@ -627,11

Re: [Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-24 Thread Jan Beulich
>>> On 24.01.18 at 17:15, wrote: > On 24/01/18 16:11, Jan Beulich wrote: > On 24.01.18 at 16:49, wrote: >>> The use of __LINE__ in a printk() is problematic for livepatching, as it >>> causes unnecessary binary differences. >>> >>>

Re: [Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-24 Thread Andrew Cooper
On 24/01/18 16:15, Andrew Cooper wrote: > On 24/01/18 16:11, Jan Beulich wrote: > On 24.01.18 at 16:49, wrote: >>> The use of __LINE__ in a printk() is problematic for livepatching, as it >>> causes unnecessary binary differences. >>> >>> Furthermore, diagnostic

Re: [Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-24 Thread Andrew Cooper
On 24/01/18 16:11, Jan Beulich wrote: On 24.01.18 at 16:49, wrote: >> The use of __LINE__ in a printk() is problematic for livepatching, as it >> causes unnecessary binary differences. >> >> Furthermore, diagnostic information around calls is inconsistent and >>

Re: [Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-24 Thread Jan Beulich
>>> On 24.01.18 at 16:49, wrote: > The use of __LINE__ in a printk() is problematic for livepatching, as it > causes unnecessary binary differences. > > Furthermore, diagnostic information around calls is inconsistent and > occasionally unhelpful. (e.g. diagnosing

[Xen-devel] [PATCH RFC] xen: Improvements to domain_crash_sync()

2018-01-24 Thread Andrew Cooper
The use of __LINE__ in a printk() is problematic for livepatching, as it causes unnecessary binary differences. Furthermore, diagnostic information around calls is inconsistent and occasionally unhelpful. (e.g. diagnosing logs from the field which might be release builds, or likely without exact