Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread Alexandru Stefan ISAILA
On 20.02.2020 14:21, George Dunlap wrote: > On 2/19/20 9:18 AM, Alexandru Stefan ISAILA wrote: >> At this moment a guest can call vmfunc to change the altp2m view. This >> should be limited in order to avoid any unwanted view switch. >> >> The new xc_altp2m_set_visibility() solves this by making

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread George Dunlap
On 2/19/20 9:18 AM, Alexandru Stefan ISAILA wrote: > At this moment a guest can call vmfunc to change the altp2m view. This > should be limited in order to avoid any unwanted view switch. > > The new xc_altp2m_set_visibility() solves this by making views invisible > to vmfunc. > This is done by

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread Jan Beulich
On 20.02.2020 10:59, Alexandru Stefan ISAILA wrote: > On 19.02.2020 19:00, Jan Beulich wrote: >> On 19.02.2020 10:18, Alexandru Stefan ISAILA wrote: >>> @@ -4835,6 +4836,23 @@ static int do_altp2m_op( >>> break; >>> } >>> >>> +case HVMOP_altp2m_set_visibility: >>> +{ >>>

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread Alexandru Stefan ISAILA
On 19.02.2020 19:00, Jan Beulich wrote: > On 19.02.2020 10:18, Alexandru Stefan ISAILA wrote: >> @@ -4835,6 +4836,23 @@ static int do_altp2m_op( >> break; >> } >> >> +case HVMOP_altp2m_set_visibility: >> +{ >> +uint16_t altp2m_idx =

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-20 Thread Alexandru Stefan ISAILA
On 19.02.2020 18:37, Tamas K Lengyel wrote: > On Wed, Feb 19, 2020 at 2:19 AM Alexandru Stefan ISAILA > wrote: >> >> At this moment a guest can call vmfunc to change the altp2m view. This >> should be limited in order to avoid any unwanted view switch. >> >> The new xc_altp2m_set_visibility()

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-19 Thread Jan Beulich
On 19.02.2020 10:18, Alexandru Stefan ISAILA wrote: > @@ -4835,6 +4836,23 @@ static int do_altp2m_op( > break; > } > > +case HVMOP_altp2m_set_visibility: > +{ > +uint16_t altp2m_idx = a.u.set_visibility.altp2m_idx; > + > +if ( a.u.set_visibility.pad ) > +

Re: [Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-19 Thread Tamas K Lengyel
On Wed, Feb 19, 2020 at 2:19 AM Alexandru Stefan ISAILA wrote: > > At this moment a guest can call vmfunc to change the altp2m view. This > should be limited in order to avoid any unwanted view switch. > > The new xc_altp2m_set_visibility() solves this by making views invisible > to vmfunc. >

[Xen-devel] [PATCH V3] x86/altp2m: Hypercall to set altp2m view visibility

2020-02-19 Thread Alexandru Stefan ISAILA
At this moment a guest can call vmfunc to change the altp2m view. This should be limited in order to avoid any unwanted view switch. The new xc_altp2m_set_visibility() solves this by making views invisible to vmfunc. This is done by having a separate arch.altp2m_working_eptp that is populated and