Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-18 Thread Alexandru Stefan ISAILA
On 18.12.2019 12:06, Jan Beulich wrote: > On 18.12.2019 10:57, Alexandru Stefan ISAILA wrote: >> On 18.12.2019 10:06, Alexandru Stefan ISAILA wrote: >>> On 17.12.2019 18:50, Jan Beulich wrote: On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: > --- a/xen/arch/x86/mm/p2m-ept.c >

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-18 Thread Jan Beulich
On 18.12.2019 10:57, Alexandru Stefan ISAILA wrote: > On 18.12.2019 10:06, Alexandru Stefan ISAILA wrote: >> On 17.12.2019 18:50, Jan Beulich wrote: >>> On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -1353,7

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-18 Thread Jan Beulich
On 18.12.2019 09:06, Alexandru Stefan ISAILA wrote: > On 17.12.2019 18:50, Jan Beulich wrote: >> On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: >>> --- a/xen/arch/x86/mm/mem_access.c >>> +++ b/xen/arch/x86/mm/mem_access.c >>> @@ -367,10 +367,11 @@ long p2m_set_mem_access(struct domain *d,

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-18 Thread Alexandru Stefan ISAILA
On 18.12.2019 10:06, Alexandru Stefan ISAILA wrote: > > > On 17.12.2019 18:50, Jan Beulich wrote: >> On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: >>> --- a/xen/arch/x86/mm/mem_access.c >>> +++ b/xen/arch/x86/mm/mem_access.c >>> @@ -367,10 +367,11 @@ long p2m_set_mem_access(struct domain

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-18 Thread Alexandru Stefan ISAILA
On 17.12.2019 18:50, Jan Beulich wrote: > On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: >> --- a/xen/arch/x86/mm/mem_access.c >> +++ b/xen/arch/x86/mm/mem_access.c >> @@ -367,10 +367,11 @@ long p2m_set_mem_access(struct domain *d, gfn_t gfn, >> uint32_t nr, >> if ( altp2m_idx ) >>

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-17 Thread Jan Beulich
On 17.12.2019 16:12, Alexandru Stefan ISAILA wrote: > --- a/xen/arch/x86/mm/mem_access.c > +++ b/xen/arch/x86/mm/mem_access.c > @@ -367,10 +367,11 @@ long p2m_set_mem_access(struct domain *d, gfn_t gfn, > uint32_t nr, > if ( altp2m_idx ) > { > if ( altp2m_idx >= MAX_ALTP2M || >

Re: [Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-17 Thread Tamas K Lengyel
On Tue, Dec 17, 2019 at 8:12 AM Alexandru Stefan ISAILA wrote: > > This patch aims to sanitize indexes, potentially guest provided > values, for altp2m_eptp[] and altp2m_p2m[] arrays. > > Signed-off-by: Alexandru Isaila LGTM, thanks! Acked-by: Tamas K Lengyel

[Xen-devel] [PATCH V4 1/4] x86/mm: Add array_index_nospec to guest provided index values

2019-12-17 Thread Alexandru Stefan ISAILA
This patch aims to sanitize indexes, potentially guest provided values, for altp2m_eptp[] and altp2m_p2m[] arrays. Signed-off-by: Alexandru Isaila --- CC: Razvan Cojocaru CC: Tamas K Lengyel CC: Petre Pircalabu CC: George Dunlap CC: Jan Beulich CC: Andrew Cooper CC: Wei Liu CC: "Roger Pau