Olaf Hering writes ("Re: [PATCH v2] libxl: prepare environment for
domcreate_stream_done"):
> Am Fri, 8 Mar 2019 14:08:10 +0000
> schrieb Ian Jackson <ian.jack...@citrix.com>:
>
> > In fact this is OK because domcreate_stream_done only reads srs->dcs
> > and then does everything with the obtained dcs. But there is nothing
> > there to indicate that srs might be mostly uninitialised. Maybe we
> > could add a comment there, something like:
> >
> > /* NB perhaps only srs->dcs is valid; eg in the case of an
> > * early branch to domcreate_bootloader_done's `out' block */
>
> I'm find with that. Can this comment be adjusted at commit time?
Sure, although if it's me that commits it I'd do it as a followup
patch.
We need a release ack I think for 4.12. Subject adjusted, CCing
Juergen. Juergen, will bounce the original patch to you too.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
