Re: [Xen-devel] [PATCH for-4.13 1/2] x86/ioapic: remove usage of TRUE and FALSE in clear_IO_APIC_pin

2019-11-07 Thread Jan Beulich
On 07.11.2019 16:06, Roger Pau Monne wrote: > And instead use proper booleans. No functional change intended. > > Signed-off-by: Roger Pau Monné Other than Andrew I think this is fine without further extension, i.e. Acked-by: Jan Beulich Of course this isn't to say that I wouldn't welcome a

Re: [Xen-devel] [PATCH for-4.13 1/2] x86/ioapic: remove usage of TRUE and FALSE in clear_IO_APIC_pin

2019-11-07 Thread Andrew Cooper
On 07/11/2019 15:06, Roger Pau Monne wrote: > And instead use proper booleans. No functional change intended. > > Signed-off-by: Roger Pau Monné > --- > Cc: Juergen Gross > --- Urgh.  Can we purge with prejudice all of this TRUE and FALSE nonsense?  There are only a few users more than this

[Xen-devel] [PATCH for-4.13 1/2] x86/ioapic: remove usage of TRUE and FALSE in clear_IO_APIC_pin

2019-11-07 Thread Roger Pau Monne
And instead use proper booleans. No functional change intended. Signed-off-by: Roger Pau Monné --- Cc: Juergen Gross --- xen/arch/x86/io_apic.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/xen/arch/x86/io_apic.c b/xen/arch/x86/io_apic.c index