Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-08 Thread Jan Beulich
On 08.11.2019 17:07, Roger Pau Monné wrote: > On Fri, Nov 08, 2019 at 11:16:26AM +0100, Jan Beulich wrote: >> On 08.11.2019 10:27, Roger Pau Monné wrote: >>> On Thu, Nov 07, 2019 at 04:56:09PM +0100, Jan Beulich wrote: On 07.11.2019 16:46, Roger Pau Monné wrote: > On Thu, Nov 07, 2019

Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-08 Thread Roger Pau Monné
On Fri, Nov 08, 2019 at 11:16:26AM +0100, Jan Beulich wrote: > On 08.11.2019 10:27, Roger Pau Monné wrote: > > On Thu, Nov 07, 2019 at 04:56:09PM +0100, Jan Beulich wrote: > >> On 07.11.2019 16:46, Roger Pau Monné wrote: > >>> On Thu, Nov 07, 2019 at 04:28:56PM +0100, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-08 Thread Jan Beulich
On 08.11.2019 10:27, Roger Pau Monné wrote: > On Thu, Nov 07, 2019 at 04:56:09PM +0100, Jan Beulich wrote: >> On 07.11.2019 16:46, Roger Pau Monné wrote: >>> On Thu, Nov 07, 2019 at 04:28:56PM +0100, Jan Beulich wrote: On 07.11.2019 16:06, Roger Pau Monne wrote: > @@ -530,9 +530,9 @@

Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-08 Thread Roger Pau Monné
On Thu, Nov 07, 2019 at 04:56:09PM +0100, Jan Beulich wrote: > On 07.11.2019 16:46, Roger Pau Monné wrote: > > On Thu, Nov 07, 2019 at 04:28:56PM +0100, Jan Beulich wrote: > >> On 07.11.2019 16:06, Roger Pau Monne wrote: > >>> @@ -530,9 +530,9 @@ static void clear_IO_APIC_pin(unsigned int apic,

Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-07 Thread Jan Beulich
On 07.11.2019 16:46, Roger Pau Monné wrote: > On Thu, Nov 07, 2019 at 04:28:56PM +0100, Jan Beulich wrote: >> On 07.11.2019 16:06, Roger Pau Monne wrote: >>> @@ -530,9 +530,9 @@ static void clear_IO_APIC_pin(unsigned int apic, >>> unsigned int pin) >>> */ >>> memset(, 0,

Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-07 Thread Roger Pau Monné
On Thu, Nov 07, 2019 at 04:46:32PM +0100, Roger Pau Monné wrote: > On Thu, Nov 07, 2019 at 04:28:56PM +0100, Jan Beulich wrote: > > On 07.11.2019 16:06, Roger Pau Monne wrote: > > > clear_IO_APIC_pin can be called after the iommu has been enabled, and > > > using raw entry reads and writes will

Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-07 Thread Roger Pau Monné
On Thu, Nov 07, 2019 at 04:28:56PM +0100, Jan Beulich wrote: > On 07.11.2019 16:06, Roger Pau Monne wrote: > > clear_IO_APIC_pin can be called after the iommu has been enabled, and > > using raw entry reads and writes will result in a misconfiguration of > > the entries already setup to use the

Re: [Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-07 Thread Jan Beulich
On 07.11.2019 16:06, Roger Pau Monne wrote: > clear_IO_APIC_pin can be called after the iommu has been enabled, and > using raw entry reads and writes will result in a misconfiguration of > the entries already setup to use the interrupt remapping table. I'm afraid I don't understand this: Raw

[Xen-devel] [PATCH for-4.13 2/2] x86/ioapic: don't use raw entry reads/writes in clear_IO_APIC_pin

2019-11-07 Thread Roger Pau Monne
clear_IO_APIC_pin can be called after the iommu has been enabled, and using raw entry reads and writes will result in a misconfiguration of the entries already setup to use the interrupt remapping table. This fixes the following panic seen on AMD Rome boxes: (XEN) [ 10.082154] ENABLING IO-APIC