Re: [Xen-devel] [PATCH for-4.13 v3] passthrough: simplify locking and logging

2019-11-20 Thread Igor Druzhinin
On 20/11/2019 15:49, Jürgen Groß wrote: > On 15.11.19 19:59, Igor Druzhinin wrote: >> From: Paul Durrant >> >> Dropping the pcidevs lock between calling device_assigned() and >> assign_device() means that the latter has to do the same check as the >> former for no obvious gain. Also, since long ru

Re: [Xen-devel] [PATCH for-4.13 v3] passthrough: simplify locking and logging

2019-11-20 Thread Jürgen Groß
On 15.11.19 19:59, Igor Druzhinin wrote: From: Paul Durrant Dropping the pcidevs lock between calling device_assigned() and assign_device() means that the latter has to do the same check as the former for no obvious gain. Also, since long running operations under pcidevs lock already drop the l

Re: [Xen-devel] [PATCH for-4.13 v3] passthrough: simplify locking and logging

2019-11-18 Thread Igor Druzhinin
On 18/11/2019 11:21, Jan Beulich wrote: > On 15.11.2019 19:59, Igor Druzhinin wrote: >> --- a/xen/drivers/passthrough/pci.c >> +++ b/xen/drivers/passthrough/pci.c >> @@ -932,30 +932,26 @@ static int deassign_device(struct domain *d, uint16_t >> seg, uint8_t bus, >> break; >>

Re: [Xen-devel] [PATCH for-4.13 v3] passthrough: simplify locking and logging

2019-11-18 Thread Jan Beulich
On 15.11.2019 19:59, Igor Druzhinin wrote: > --- a/xen/drivers/passthrough/pci.c > +++ b/xen/drivers/passthrough/pci.c > @@ -932,30 +932,26 @@ static int deassign_device(struct domain *d, uint16_t > seg, uint8_t bus, > break; > ret = hd->platform_ops->reassign_device(d, targe

[Xen-devel] [PATCH for-4.13 v3] passthrough: simplify locking and logging

2019-11-15 Thread Igor Druzhinin
From: Paul Durrant Dropping the pcidevs lock between calling device_assigned() and assign_device() means that the latter has to do the same check as the former for no obvious gain. Also, since long running operations under pcidevs lock already drop the lock and return -ERESTART periodically there