Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

Olaf Hering writes ("Re: [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume"): > Am Thu, 17 May 2018 17:51:08 +0200 > schrieb Olaf Hering : > > > @@ -377,7 +377,9 @@ static void > > domain_suspend_common_guest_suspended(libxl__egc *egc, > > +

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

Am Thu, 17 May 2018 17:51:08 +0200 schrieb Olaf Hering : > @@ -377,7 +377,9 @@ static void > domain_suspend_common_guest_suspended(libxl__egc *egc, > +libxl__device_model_version_running(gc, dsps->domid) == > +LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN) { Please withdraw that patch.

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

On Fri, May 18, 2018 at 06:01:42PM +0100, Wei Liu wrote: > Cc Anthony. > > On Thu, May 17, 2018 at 05:51:08PM +0200, Olaf Hering wrote: > > If a domU has a qemu-xen instance attached, it is required to call qemus > > "xen-save-devices-state" method. Without it, the receiving side of a PV > >

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

Am Tue, 22 May 2018 12:14:29 +0100 schrieb Wei Liu : > I think your predicate is correct. Sorry for the noise. Is there anything else to be done to get this fixed? Olaf pgpyQZGDs0CyK.pgp Description: Digitale Signatur von OpenPGP

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

On Tue, May 22, 2018 at 10:52:20AM +0200, Olaf Hering wrote: > Am Mon, 21 May 2018 09:18:20 +0100 > schrieb Wei Liu : > > > What I mean is: now you seem to want to call > > libxl__domain_suspend_device_model when QEMU upstream is running, > > regardless of whether a guest is

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

Am Mon, 21 May 2018 09:18:20 +0100 schrieb Wei Liu : > What I mean is: now you seem to want to call > libxl__domain_suspend_device_model when QEMU upstream is running, > regardless of whether a guest is HVM or PV, so the check for HVM should > be gone.

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

On Fri, May 18, 2018 at 09:09:10PM +0200, Olaf Hering wrote: > Am Fri, 18 May 2018 18:01:42 +0100 > schrieb Wei Liu : > > > You don't need to test if the guest is HVM anymore. You only need to > > know if QEMU upstream is running. > > libxl__domain_suspend_device_model

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

Am Fri, 18 May 2018 18:01:42 +0100 schrieb Wei Liu : > You don't need to test if the guest is HVM anymore. You only need to > know if QEMU upstream is running. libxl__domain_suspend_device_model handles qemu-xen and qemu-xen-trad. That function can not be called

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

Cc Anthony. On Thu, May 17, 2018 at 05:51:08PM +0200, Olaf Hering wrote: > If a domU has a qemu-xen instance attached, it is required to call qemus > "xen-save-devices-state" method. Without it, the receiving side of a PV > migration may be unable to lock the image: > > xen be: qdisk-51712: xen

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

On Fri, May 18, 2018 at 09:25:07AM +0200, Juergen Gross wrote: > On 17/05/18 17:51, Olaf Hering wrote: > > If a domU has a qemu-xen instance attached, it is required to call qemus > > "xen-save-devices-state" method. Without it, the receiving side of a PV > > migration may be unable to lock the

Re: [Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

Am Fri, 18 May 2018 09:25:07 +0200 schrieb Juergen Gross : > debianhvm The patch is for non-HVM, so perhaps these failures are something else. To me it was not clear from the faillog what exactly failed. Olaf pgpY2ULaICJiC.pgp Description: Digitale Signatur von OpenPGP

[Xen-devel] [PATCH v1] libxl: always call qemus xen-save-devices-state in suspend/resume

If a domU has a qemu-xen instance attached, it is required to call qemus "xen-save-devices-state" method. Without it, the receiving side of a PV migration may be unable to lock the image: xen be: qdisk-51712: xen be: qdisk-51712: error: Failed to get "write" lock error: Failed to get "write" lock