Re: [Xen-devel] [PATCH v10 11/11] vpci/msix: add MSI-X handlers

2018-03-20 Thread Roger Pau Monné
On Tue, Mar 20, 2018 at 07:10:39AM -0600, Jan Beulich wrote: > >>> On 20.03.18 at 12:43, wrote: > > Since you only had comments on patch 7 and 11 and there's the extra > > fix for the test harness, should I just send those and provide you > > with a git branch that contains

Re: [Xen-devel] [PATCH v10 11/11] vpci/msix: add MSI-X handlers

2018-03-20 Thread Jan Beulich
>>> On 20.03.18 at 12:43, wrote: > Since you only had comments on patch 7 and 11 and there's the extra > fix for the test harness, should I just send those and provide you > with a git branch that contains the rest? Well, if it's not too much hassle for you I'd prefer if

Re: [Xen-devel] [PATCH v10 11/11] vpci/msix: add MSI-X handlers

2018-03-20 Thread Roger Pau Monné
On Tue, Mar 20, 2018 at 11:43:00AM +, Roger Pau Monné wrote: > On Tue, Mar 20, 2018 at 05:03:09AM -0600, Jan Beulich wrote: > > >>> On 16.03.18 at 14:30, wrote: > > > +printk(XENLOG_G_WARNING > > > + "Failed to remove MSIX table [%" PRI_gfn

Re: [Xen-devel] [PATCH v10 11/11] vpci/msix: add MSI-X handlers

2018-03-20 Thread Roger Pau Monné
On Tue, Mar 20, 2018 at 05:03:09AM -0600, Jan Beulich wrote: > >>> On 16.03.18 at 14:30, wrote: > > +int vpci_msix_arch_print(const struct vpci_msix *msix) > > +{ > > +unsigned int i; > > + > > +for ( i = 0; i < msix->max_entries; i++ ) > > +{ > > +const

Re: [Xen-devel] [PATCH v10 11/11] vpci/msix: add MSI-X handlers

2018-03-20 Thread Jan Beulich
>>> On 16.03.18 at 14:30, wrote: > +int vpci_msix_arch_print(const struct vpci_msix *msix) > +{ > +unsigned int i; > + > +for ( i = 0; i < msix->max_entries; i++ ) > +{ > +const struct vpci_msix_entry *entry = >entries[i]; > + > +printk("%6u

[Xen-devel] [PATCH v10 11/11] vpci/msix: add MSI-X handlers

2018-03-16 Thread Roger Pau Monne
Add handlers for accesses to the MSI-X message control field on the PCI configuration space, and traps for accesses to the memory region that contains the MSI-X table and PBA. This traps detect attempts from the guest to configure MSI-X interrupts and properly sets them up. Note that accesses to