Re: [Xen-devel] [PATCH v14 8/9] mm / iommu: include need_iommu() test in iommu_use_hap_pt()

2018-10-05 Thread Paul Durrant
ct: Re: [Xen-devel] [PATCH v14 8/9] mm / iommu: include need_iommu() > test in iommu_use_hap_pt() > > This patch has broken my PVH Dom0 setup. Hmm. This is probably a bug in the need_iommu() setting for dom0. Do you still see the problem with the subsequent patch " mm /

Re: [Xen-devel] [PATCH v14 8/9] mm / iommu: include need_iommu() test in iommu_use_hap_pt()

2018-10-05 Thread Wei Liu
This patch has broken my PVH Dom0 setup. [2.515159] igb :02:00.1: added PHC on eth1 [2.519539] igb :02:00.1: Intel(R) Gigabit Ethernet Network Connection [2.526469] igb :02:00.1: eth1: (PCIe:5.0Gb/s:Width x4) 0c:c4:7a:e7:b6:53 [2.533733] igb :02:00.1: eth1: PBA No:

Re: [Xen-devel] [PATCH v14 8/9] mm / iommu: include need_iommu() test in iommu_use_hap_pt()

2018-10-04 Thread George Dunlap
On 10/04/2018 11:45 AM, Paul Durrant wrote: > The name 'iommu_use_hap_pt' suggests that that P2M table is in use as the > domain's IOMMU pagetable which, prior to this patch, is not strictly true > since the macro did not test whether the domain actually has IOMMU > mappings. > > Signed-off-by:

Re: [Xen-devel] [PATCH v14 8/9] mm / iommu: include need_iommu() test in iommu_use_hap_pt()

2018-10-04 Thread Jan Beulich
>>> On 04.10.18 at 12:45, wrote: > The name 'iommu_use_hap_pt' suggests that that P2M table is in use as the > domain's IOMMU pagetable which, prior to this patch, is not strictly true > since the macro did not test whether the domain actually has IOMMU > mappings. > > Signed-off-by: Paul

[Xen-devel] [PATCH v14 8/9] mm / iommu: include need_iommu() test in iommu_use_hap_pt()

2018-10-04 Thread Paul Durrant
The name 'iommu_use_hap_pt' suggests that that P2M table is in use as the domain's IOMMU pagetable which, prior to this patch, is not strictly true since the macro did not test whether the domain actually has IOMMU mappings. Signed-off-by: Paul Durrant Reviewed-by: Kevin Tian Acked-by: Julien