Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jan Beulich
On 16.12.2019 12:51, Jin Nan Wang wrote: > > On 16/12/2019 7:00 pm, Jan Beulich wrote: >> On 16.12.2019 09:27, Jin Nan Wang wrote: >>> Fix a issue when user disable ETP exec-sp, xen missed a prompt >>> log in dmesg. >> Why "missed" (and why "prompt")? I think the original intention >> was to log

Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jin Nan Wang
On 16/12/2019 7:00 pm, Jan Beulich wrote: > On 16.12.2019 09:27, Jin Nan Wang wrote: >> Fix a issue when user disable ETP exec-sp, xen missed a prompt >> log in dmesg. > Why "missed" (and why "prompt")? I think the original intention > was to log a message only when no command line option was

Re: [Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jan Beulich
On 16.12.2019 09:27, Jin Nan Wang wrote: > Fix a issue when user disable ETP exec-sp, xen missed a prompt > log in dmesg. Why "missed" (and why "prompt")? I think the original intention was to log a message only when no command line option was given and the system would be vulnerable without the

[Xen-devel] [PATCH v2] Xen missing prompt log when exec-sp=off

2019-12-16 Thread Jin Nan Wang
Fix a issue when user disable ETP exec-sp, xen missed a prompt log in dmesg. Signed-off-by: James Wang --- xen/arch/x86/hvm/vmx/vmx.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/xen/arch/x86/hvm/vmx/vmx.c b/xen/arch/x86/hvm/vmx/vmx.c index