Re: [Xen-devel] [PATCH v2] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Wei Liu
On Wed, Feb 05, 2020 at 11:29:30AM +, Anthony PERARD wrote: > On Wed, Feb 05, 2020 at 11:24:12AM +, Paul Durrant wrote: > > NOTE: The comment for XEN_DOMCTL_createdomain in domctl.h is changed to > > reflect reality. > > Surely, this change deserve to be in its own patch, isn't it?

Re: [Xen-devel] [PATCH v2] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Anthony PERARD
On Wed, Feb 05, 2020 at 11:24:12AM +, Paul Durrant wrote: > NOTE: The comment for XEN_DOMCTL_createdomain in domctl.h is changed to > reflect reality. Surely, this change deserve to be in its own patch, isn't it? -- Anthony PERARD ___ Xen-de

Re: [Xen-devel] [PATCH v2] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Jan Beulich
On 05.02.2020 12:24, Paul Durrant wrote: > --- a/xen/include/public/domctl.h > +++ b/xen/include/public/domctl.h > @@ -42,7 +42,8 @@ > > /* > * NB. xen_domctl.domain is an IN/OUT parameter for this operation. > - * If it is specified as zero, an id is auto-allocated and returned. > + * If it i

Re: [Xen-devel] [PATCH v2] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Wei Liu
On Wed, Feb 05, 2020 at 11:24:12AM +, Paul Durrant wrote: > An assertion in libxl__domain_make(): > > 'soft_reset || *domid == INVALID_DOMID' > > does not hold true for stub domain creation, where soft_reset is false > but the passed in domid == 0. This is easily fixed by changing the > initi

[Xen-devel] [PATCH v2] libxl: fix assertion failure in stub domain creation

2020-02-05 Thread Paul Durrant
An assertion in libxl__domain_make(): 'soft_reset || *domid == INVALID_DOMID' does not hold true for stub domain creation, where soft_reset is false but the passed in domid == 0. This is easily fixed by changing the initializer in libxl__spawn_stub_dm(). NOTE: The comment for XEN_DOMCTL_createdo