Re: [Xen-devel] [PATCH v2] xen/arm: remove physical timer offset

2019-12-12 Thread Julien Grall
Hi, On 11/12/2019 20:00, Jeff Kubascik wrote: On 12/5/2019 3:28 PM, Julien Grall wrote: However, set_timer expects a signed 64 bit value in ns. The conversion of cval (unsigned 64 bit) from ticks to ns is going to overflow this. I'm not sure what would be the best way to work around this

Re: [Xen-devel] [PATCH v2] xen/arm: remove physical timer offset

2019-12-11 Thread Jeff Kubascik
On 12/5/2019 3:28 PM, Julien Grall wrote: > Hi, > > On 05/12/2019 19:17, Jeff Kubascik wrote: >> On 12/3/2019 1:04 PM, Julien Grall wrote: >>> Hi, >>> >>> On 26/11/2019 21:13, Jeff Kubascik wrote: The physical timer traps apply an offset so that time starts at 0 for the guest. However,

Re: [Xen-devel] [PATCH v2] xen/arm: remove physical timer offset

2019-12-05 Thread Julien Grall
Hi, On 05/12/2019 19:17, Jeff Kubascik wrote: On 12/3/2019 1:04 PM, Julien Grall wrote: Hi, On 26/11/2019 21:13, Jeff Kubascik wrote: The physical timer traps apply an offset so that time starts at 0 for the guest. However, this offset is not currently applied to the physical counter. Per

Re: [Xen-devel] [PATCH v2] xen/arm: remove physical timer offset

2019-12-05 Thread Jeff Kubascik
On 12/3/2019 1:04 PM, Julien Grall wrote: > Hi, > > On 26/11/2019 21:13, Jeff Kubascik wrote: >> The physical timer traps apply an offset so that time starts at 0 for >> the guest. However, this offset is not currently applied to the physical >> counter. Per the ARMv8 Reference Manual (ARM DDI

Re: [Xen-devel] [PATCH v2] xen/arm: remove physical timer offset

2019-12-03 Thread Julien Grall
Hi, On 26/11/2019 21:13, Jeff Kubascik wrote: The physical timer traps apply an offset so that time starts at 0 for the guest. However, this offset is not currently applied to the physical counter. Per the ARMv8 Reference Manual (ARM DDI 0487E.a), section D11.2.4 Timers, the "Offset" between

[Xen-devel] [PATCH v2] xen/arm: remove physical timer offset

2019-11-26 Thread Jeff Kubascik
The physical timer traps apply an offset so that time starts at 0 for the guest. However, this offset is not currently applied to the physical counter. Per the ARMv8 Reference Manual (ARM DDI 0487E.a), section D11.2.4 Timers, the "Offset" between the counter and timer should be zero for a physical