Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-09-11 Thread Jan Beulich
>>> On 10.09.18 at 19:51, wrote: > On 10/09/18 14:29, Jan Beulich wrote: > On 10.09.18 at 15:21, wrote: >> On 31.08.18 at 10:43, wrote: >>> On 31.08.18 at 10:29, wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -11,6 +11,13 @@ config DEBUG > >

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-09-10 Thread Andrew Cooper
On 10/09/18 14:29, Jan Beulich wrote: On 10.09.18 at 15:21, wrote: > On 31.08.18 at 10:43, wrote: >> On 31.08.18 at 10:29, wrote: --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -11,6 +11,13 @@ config DEBUG You probably want to say 'N' here.

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-09-10 Thread Jan Beulich
>>> On 10.09.18 at 15:21, wrote: On 31.08.18 at 10:43, wrote: > On 31.08.18 at 10:29, wrote: >>> --- a/xen/Kconfig.debug >>> +++ b/xen/Kconfig.debug >>> @@ -11,6 +11,13 @@ config DEBUG >>> >>> You probably want to say 'N' here. >>> >>> +config DEBUG_INFO >>> + bool "Compile

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-09-10 Thread Jan Beulich
>>> On 31.08.18 at 10:43, wrote: On 31.08.18 at 10:29, wrote: >> --- a/xen/Kconfig.debug >> +++ b/xen/Kconfig.debug >> @@ -11,6 +11,13 @@ config DEBUG >> >>You probably want to say 'N' here. >> >> +config DEBUG_INFO >> +bool "Compile Xen with debug info" >> +default y >>

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Jan Beulich
>>> On 31.08.18 at 11:50, wrote: > On 08/31/2018 10:25 AM, Jan Beulich wrote: > On 31.08.18 at 11:02, wrote: >>> On Fri, Aug 31, Jan Beulich wrote: >>> Perhaps better move your addition into this conditional section? >>> >>> Then -g would disappear when DEBUG is disabled. Is that

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Julien Grall
Hi Jan, On 08/31/2018 10:25 AM, Jan Beulich wrote: On 31.08.18 at 11:02, wrote: On Fri, Aug 31, Jan Beulich wrote: Perhaps better move your addition into this conditional section? Then -g would disappear when DEBUG is disabled. Is that intentional? It would still be available when

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Jan Beulich
>>> On 31.08.18 at 11:02, wrote: > On Fri, Aug 31, Jan Beulich wrote: > >> Perhaps better move your addition into this conditional section? > > Then -g would disappear when DEBUG is disabled. Is that intentional? It would still be available when EXPERT=y. Jan

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Olaf Hering
On Fri, Aug 31, Jan Beulich wrote: > Perhaps better move your addition into this conditional section? Then -g would disappear when DEBUG is disabled. Is that intentional? Olaf signature.asc Description: PGP signature ___ Xen-devel mailing list

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Wei Liu
On Fri, Aug 31, 2018 at 09:51:50AM +0100, Andrew Cooper wrote: > On 31/08/18 09:41, Jan Beulich wrote: > On 31.08.18 at 10:32, wrote: > >> On Fri, Aug 31, 2018 at 10:29:21AM +0200, Olaf Hering wrote: > >>> Creating debug info during build is not strictly required at runtime. > >>> Make it

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Andrew Cooper
On 31/08/18 09:41, Jan Beulich wrote: On 31.08.18 at 10:32, wrote: >> On Fri, Aug 31, 2018 at 10:29:21AM +0200, Olaf Hering wrote: >>> Creating debug info during build is not strictly required at runtime. >>> Make it optional by introducing a new Kconfig knob "DEBUG_INFO". >>> This slightly

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Jan Beulich
>>> On 31.08.18 at 10:29, wrote: > --- a/xen/Kconfig.debug > +++ b/xen/Kconfig.debug > @@ -11,6 +11,13 @@ config DEBUG > > You probably want to say 'N' here. > > +config DEBUG_INFO > + bool "Compile Xen with debug info" > + default y > + ---help--- > + If you say Y

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Jan Beulich
>>> On 31.08.18 at 10:32, wrote: > On Fri, Aug 31, 2018 at 10:29:21AM +0200, Olaf Hering wrote: >> Creating debug info during build is not strictly required at runtime. >> Make it optional by introducing a new Kconfig knob "DEBUG_INFO". >> This slightly reduces build time and diskusage, if

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Olaf Hering
On Fri, Aug 31, Wei Liu wrote: > But what is the difference between this and DEBUG anyway? DEBUG_INFO is for gcc (-g), DEBUG is for Kconfig. Adding a dependency to DEBUG may change behavior, not sure what the expected outcome of always using '-g' is. Olaf signature.asc Description: PGP

Re: [Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Wei Liu
On Fri, Aug 31, 2018 at 10:29:21AM +0200, Olaf Hering wrote: > Creating debug info during build is not strictly required at runtime. > Make it optional by introducing a new Kconfig knob "DEBUG_INFO". > This slightly reduces build time and diskusage, if disabled. > > Signed-off-by: Olaf Hering >

[Xen-devel] [PATCH v2] xen: add DEBUG_INFO Kconfig symbol

2018-08-31 Thread Olaf Hering
Creating debug info during build is not strictly required at runtime. Make it optional by introducing a new Kconfig knob "DEBUG_INFO". This slightly reduces build time and diskusage, if disabled. Signed-off-by: Olaf Hering --- xen/Kconfig.debug | 7 +++ xen/Rules.mk | 5 - 2 files