Re: [Xen-devel] [PATCH v2 01/22] golang/xenlight: generate enum types from IDL

2019-12-05 Thread Nick Rosbrook
> Sorry to come back to this... I think this would be better explicitly > listing out the files that are needed. As I said, the current way of > doing things means gengotypes.py will *always* be re-run; and the > result, when experimenting with the `typeof` before, was that my local > changes to

Re: [Xen-devel] [PATCH v2 01/22] golang/xenlight: generate enum types from IDL

2019-12-05 Thread George Dunlap
On 11/15/19 7:44 PM, Nick Rosbrook wrote: > diff --git a/tools/golang/xenlight/Makefile b/tools/golang/xenlight/Makefile > index 0987305224..681f32c234 100644 > --- a/tools/golang/xenlight/Makefile > +++ b/tools/golang/xenlight/Makefile > @@ -7,20 +7,21 @@ GOCODE_DIR ?= $(prefix)/share/gocode/ >

Re: [Xen-devel] [PATCH v2 01/22] golang/xenlight: generate enum types from IDL

2019-12-04 Thread George Dunlap
On 11/15/19 7:44 PM, Nick Rosbrook wrote: > From: Nick Rosbrook > > Introduce gengotypes.py to generate Go code the from IDL. As a first step, > implement 'enum' type generation. > > As a result of the newly-generated code, remove the existing, and now > conflicting definitions in xenlight.go.

Re: [Xen-devel] [PATCH v2 01/22] golang/xenlight: generate enum types from IDL

2019-12-03 Thread George Dunlap
> On Nov 15, 2019, at 7:44 PM, Nick Rosbrook wrote: > > From: Nick Rosbrook > > Introduce gengotypes.py to generate Go code the from IDL. As a first step, > implement 'enum' type generation. > > As a result of the newly-generated code, remove the existing, and now > conflicting definitions

[Xen-devel] [PATCH v2 01/22] golang/xenlight: generate enum types from IDL

2019-11-15 Thread Nick Rosbrook
From: Nick Rosbrook Introduce gengotypes.py to generate Go code the from IDL. As a first step, implement 'enum' type generation. As a result of the newly-generated code, remove the existing, and now conflicting definitions in xenlight.go. In the case of the Error type, rename the slice 'errors'