Re: [Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-25 Thread Julien Grall
On 04/24/2018 03:50 PM, Mirela Simonovic wrote: Hi Julien, Hi, Sorry I forgot to answer to some part of the e-mail. On Mon, Apr 23, 2018 at 1:28 PM, Julien Grall wrote: Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: diff --git a/xen/arch/arm/p2m.c

Re: [Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-24 Thread Julien Grall
On 04/24/2018 03:50 PM, Mirela Simonovic wrote: Hi Julien, Hi Mirela, Thanks for the feedback. On Mon, Apr 23, 2018 at 1:28 PM, Julien Grall wrote: Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: In existing code the paging for non-boot CPUs is setup only

Re: [Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-24 Thread Mirela Simonovic
Hi Julien, Thanks for the feedback. On Mon, Apr 23, 2018 at 1:28 PM, Julien Grall wrote: > Hi Mirela, > > > On 20/04/18 13:25, Mirela Simonovic wrote: >> >> In existing code the paging for non-boot CPUs is setup only on boot. The >> setup is triggered from start_xen()

Re: [Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-23 Thread Julien Grall
Hi Mirela, On 20/04/18 13:25, Mirela Simonovic wrote: In existing code the paging for non-boot CPUs is setup only on boot. The setup is triggered from start_xen() after all CPUs are brought online. In other words, the initialization of VTCR_EL2 register is done out of the

[Xen-devel] [PATCH v2 05/10] xen/arm: Setup virtual paging for non-boot CPUs on hotplug/resume

2018-04-20 Thread Mirela Simonovic
In existing code the paging for non-boot CPUs is setup only on boot. The setup is triggered from start_xen() after all CPUs are brought online. In other words, the initialization of VTCR_EL2 register is done out of the cpu_up/start_secondary() control flow. However, the cpu_up flow is also used to