> -Original Message-
[snip]
> > >
> > > return 0;
> > >
> > > fail_add:
> > > +ASSERT(!hvm_ioreq_is_internal(id));
> > > hvm_ioreq_server_remove_all_vcpus(s);
> > > hvm_ioreq_server_unmap_pages(s);
> > >
> >
> > I think it would be worthwhile having that ASSERT repeated
On Fri, Sep 20, 2019 at 01:15:06PM +0200, Jan Beulich wrote:
> On 03.09.2019 18:14, Roger Pau Monne wrote:
> > @@ -821,6 +851,9 @@ int hvm_create_ioreq_server(struct domain *d, int
> > bufioreq_handling,
> > if ( i >= MAX_NR_IOREQ_SERVERS )
> > goto fail;
> >
> > +ASSERT((inter
On Tue, Sep 10, 2019 at 02:59:57PM +0200, Paul Durrant wrote:
> > -Original Message-
> > From: Roger Pau Monne
> > Sent: 03 September 2019 17:14
> > To: xen-devel@lists.xenproject.org
> > Cc: Roger Pau Monne ; Jan Beulich
> > ; Andrew Cooper
> > ; Wei Liu ; Paul Durrant
> >
> > Subject:
On 03.09.2019 18:14, Roger Pau Monne wrote:
> @@ -821,6 +851,9 @@ int hvm_create_ioreq_server(struct domain *d, int
> bufioreq_handling,
> if ( i >= MAX_NR_IOREQ_SERVERS )
> goto fail;
>
> +ASSERT((internal &&
> +i >= MAX_NR_EXTERNAL_IOREQ_SERVERS && i < MAX_NR_IORE
> -Original Message-
> From: Roger Pau Monne
> Sent: 03 September 2019 17:14
> To: xen-devel@lists.xenproject.org
> Cc: Roger Pau Monne ; Jan Beulich ;
> Andrew Cooper
> ; Wei Liu ; Paul Durrant
>
> Subject: [PATCH v2 05/11] ioreq: add internal ioreq initialization support
>
> Add supp
Add support for internal ioreq servers to initialization and
deinitialization routines, prevent some functions from being executed
against internal ioreq servers and add guards to only allow internal
callers to modify internal ioreq servers. External callers (ie: from
hypercalls) are only allowed t
