Re: [Xen-devel] [PATCH v2 09/21] xen/arm: move cmdline out of boot_modules

2018-07-12 Thread Stefano Stabellini
On Tue, 10 Jul 2018, Julien Grall wrote: > Hi Stefano, > > On 10/07/2018 01:00, Stefano Stabellini wrote: > > On Mon, 9 Jul 2018, Julien Grall wrote: > > > Hi, > > > > > > On 07/07/18 00:12, Stefano Stabellini wrote: > > > > Remove the cmdline field from struct boot_module, cmdline is stored > >

Re: [Xen-devel] [PATCH v2 09/21] xen/arm: move cmdline out of boot_modules

2018-07-10 Thread Julien Grall
Hi Stefano, On 10/07/2018 01:00, Stefano Stabellini wrote: On Mon, 9 Jul 2018, Julien Grall wrote: Hi, On 07/07/18 00:12, Stefano Stabellini wrote: Remove the cmdline field from struct boot_module, cmdline is stored independently out of the boot_modules array as dom0_cmdline. I am not

Re: [Xen-devel] [PATCH v2 09/21] xen/arm: move cmdline out of boot_modules

2018-07-09 Thread Stefano Stabellini
On Mon, 9 Jul 2018, Julien Grall wrote: > Hi, > > On 07/07/18 00:12, Stefano Stabellini wrote: > > Remove the cmdline field from struct boot_module, cmdline is stored > > independently out of the boot_modules array as dom0_cmdline. > > I am not entirely convince of this patch, this does not seem

Re: [Xen-devel] [PATCH v2 09/21] xen/arm: move cmdline out of boot_modules

2018-07-09 Thread Julien Grall
Hi, On 07/07/18 00:12, Stefano Stabellini wrote: Remove the cmdline field from struct boot_module, cmdline is stored independently out of the boot_modules array as dom0_cmdline. I am not entirely convince of this patch, this does not seem to go towards a better code base because dom0_cmdline

[Xen-devel] [PATCH v2 09/21] xen/arm: move cmdline out of boot_modules

2018-07-06 Thread Stefano Stabellini
Remove the cmdline field from struct boot_module, cmdline is stored independently out of the boot_modules array as dom0_cmdline. Add a pointer to struct kernel_info to point to the cmdline for a given kernel. boot_fdt_cmdline is only used to retrieve the Xen cmdline. Remove the code to return